bpo-40389: Improve repr of typing.Optional#19714
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
|
|
||
| def __repr__(self): | ||
| if (self.__origin__ == Union and len(self.__args__) == 2 | ||
| and self.__args__[1] is type(None)): |
There was a problem hiding this comment.
Hi @Endilll, thanks for opening a pull request for this. Notice that this does not work, when None is the first element:
>>> import typing
>>> typing.Union[None, int]
typing.Union[NoneType, int]
>>> typing.Union[None, int] == typing.Optional[int]
True
This change will also need some tests and an NEWS entry.
There was a problem hiding this comment.
Thank you for the feedback. Fixed.
|
You can add a NEWS entry using https://blurb-it.herokuapp.com/ |
|
Thanks for the PR and welcome @Endilll. FYI: assuming the idea is approved by the maintainers of |
ilevkivskyi
left a comment
ilevkivskyi
left a comment
There was a problem hiding this comment.
Looks good, thanks! Also be sure to sign the CLA.
The Azure failure look like a flake, but I can't re-trigger it, and it is required for merging. @zooba do you know how to fix this?
gvanrossum
left a comment
gvanrossum
left a comment
There was a problem hiding this comment.
LGTM. Please sign the CLA so we can merge.
|
I've submitted CLA back on Saturday, and bot says that one business day is needed to update the records, so I suppose we just need to wait a bit. |
|
Closing and reopening to re-run the Azure pipelines. |
|
@gvanrossum: Please replace |
|
Congratulations! |
|
I want to thank everybody for such a welcoming attitude. |
7 participants
https://bugs.python.org/issue40389