Skip to content

bpo-40260: Remove unnecessary newline in compile() call#19641

Merged
zooba merged 1 commit into
python:masterfrom
asottile:remove_unnecessary_newline
Apr 22, 2020
Merged

bpo-40260: Remove unnecessary newline in compile() call#19641
zooba merged 1 commit into
python:masterfrom
asottile:remove_unnecessary_newline

Conversation

@asottile

@asottile asottile commented Apr 22, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

this should fix debian's modulefinder subclass

I didn't have a great way to test this unfortunately :(

https://bugs.python.org/issue40260

@zooba

zooba commented Apr 22, 2020

Copy link
Copy Markdown
Member

Just going to close/reopen to trigger Azure Pipelines again. (Seems there's a bug in some of the concurrency tests right now...)

@zooba zooba closed this Apr 22, 2020
@zooba zooba reopened this Apr 22, 2020
@zooba
zooba merged commit 39652cd into python:master Apr 22, 2020
@miss-islington

miss-islington commented Apr 22, 2020

Copy link
Copy Markdown
Contributor

Thanks @asottile for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 22, 2020
@asottile @miss-islington
bpo-40260: Remove unnecessary newline in compile() call (pythonGH-19641)
53e8276 
Because some people subclass this class and call undocumented methods, and we don't want to break them.
(cherry picked from commit 39652cd)

Co-authored-by: Anthony Sottile <asottile@umich.edu>
@bedevere-bot

bedevere-bot commented Apr 22, 2020

Copy link
Copy Markdown

GH-19659 is a backport of this pull request to the 3.8 branch.

@bedevere-bot

bedevere-bot commented Apr 22, 2020

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Debian 3.x has failed when building commit 39652cd.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/105/builds/826) and take a look at the build logs.
  4. Check if the failure is related to this commit (39652cd) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/105/builds/826

Summary of the results of the build (if available):

== Tests result: ENV CHANGED ==

407 tests OK.

10 slowest tests:

  • test_concurrent_futures: 3 min 8 sec
  • test_multiprocessing_spawn: 2 min 37 sec
  • test_gdb: 1 min 54 sec
  • test_capi: 1 min 53 sec
  • test_tokenize: 1 min 51 sec
  • test_multiprocessing_forkserver: 1 min 50 sec
  • test_unparse: 1 min 39 sec
  • test_multiprocessing_fork: 1 min 28 sec
  • test_lib2to3: 1 min 17 sec
  • test_asyncio: 1 min 14 sec

1 test altered the execution environment:
test_concurrent_futures

13 tests skipped:
test_devpoll test_ioctl test_kqueue test_msilib test_ossaudiodev
test_startfile test_tix test_tk test_ttk_guionly test_winconsoleio
test_winreg test_winsound test_zipfile64

Total duration: 7 min 25 sec

Click to see traceback logs 
remote: Enumerating objects: 4, done.        
remote: Counting objects:  25% (1/4)        
remote: Counting objects:  50% (2/4)        
remote: Counting objects:  75% (3/4)        
remote: Counting objects: 100% (4/4)        
remote: Counting objects: 100% (4/4), done.        
remote: Total 4 (delta 3), reused 4 (delta 3), pack-reused 0        
From https://github.com/python/cpython
 * branch                  master     -> FETCH_HEAD
Reset branch 'master'

test_ttk_guionly skipped -- Tk unavailable due to TclError: no display name and no $DISPLAY environment variab [...]
test_winreg skipped -- No module named 'winreg'
test_flock (__main__.FNTLEINTRTest) ... ok
test_lockf (__main__.FNTLEINTRTest) ... ok
test_read (__main__.OSEINTRTest) ... ok
test_wait (__main__.OSEINTRTest) ... ok
test_wait3 (__main__.OSEINTRTest) ... ok
test_wait4 (__main__.OSEINTRTest) ... ok
test_waitpid (__main__.OSEINTRTest) ... ok
test_write (__main__.OSEINTRTest) ... ok
test_devpoll (__main__.SelectEINTRTest) ... skipped 'need select.devpoll'
test_epoll (__main__.SelectEINTRTest) ... ok
test_kqueue (__main__.SelectEINTRTest) ... skipped 'need select.kqueue'
test_poll (__main__.SelectEINTRTest) ... ok
test_select (__main__.SelectEINTRTest) ... ok
test_sigtimedwait (__main__.SignalEINTRTest) ... ok
test_sigwaitinfo (__main__.SignalEINTRTest) ... ok
test_accept (__main__.SocketEINTRTest) ... ok
test_open (__main__.SocketEINTRTest) ... ok
test_os_open (__main__.SocketEINTRTest) ... ok
test_recv (__main__.SocketEINTRTest) ... ok
test_recvmsg (__main__.SocketEINTRTest) ... ok
test_send (__main__.SocketEINTRTest) ... ok
test_sendall (__main__.SocketEINTRTest) ... ok
test_sendmsg (__main__.SocketEINTRTest) ... ok
test_sleep (__main__.TimeEINTRTest) ... ok

----------------------------------------------------------------------
Ran 24 tests in 7.191s

OK (skipped=2)
test_winsound skipped -- No module named 'winsound'
test_startfile skipped -- object <module 'os' from '/home/dje/cpython-buildarea/3.x.edelsohn-debian-z/build/Lib/os.py'> has no attribute 'startfile'
test_ossaudiodev skipped -- [Errno 2] No such file or directory: '/dev/dsp'
test_tix skipped -- Tk unavailable due to TclError: no display name and no $DISPLAY environment variab [...]
test_zipfile64 skipped -- test requires loads of disk-space bytes and a long time to run
test_msilib skipped -- No module named '_msi'
test_kqueue skipped -- test works only on BSD
test_devpoll skipped -- test works only on Solaris OS family
test_tk skipped -- Tk unavailable due to TclError: no display name and no $DISPLAY environment variab [...]
/home/dje/cpython-buildarea/3.x.edelsohn-debian-z/build/Lib/multiprocessing/resource_tracker.py:216: UserWarning: resource_tracker: There appear to be 1 leaked shared_memory objects to clean up at shutdown
  warnings.warn('resource_tracker: There appear to be %d '
/home/dje/cpython-buildarea/3.x.edelsohn-debian-z/build/Lib/multiprocessing/resource_tracker.py:229: UserWarning: resource_tracker: '/psm_5a27daba': [Errno 2] No such file or directory: '/psm_5a27daba'
  warnings.warn('resource_tracker: %r: %s' % (name, e))
test_winconsoleio skipped -- test only relevant on win32
stty: 'standard input': Inappropriate ioctl for device
test_ioctl skipped -- Unable to open /dev/tty
test_cancel (test.test_concurrent_futures.FutureTests) ... ok
test_cancelled (test.test_concurrent_futures.FutureTests) ... ok
test_done (test.test_concurrent_futures.FutureTests) ... ok
test_done_callback_already_cancelled (test.test_concurrent_futures.FutureTests) ... ok
test_done_callback_already_failed (test.test_concurrent_futures.FutureTests) ... ok
test_done_callback_already_successful (test.test_concurrent_futures.FutureTests) ... ok
test_done_callback_raises (test.test_concurrent_futures.FutureTests) ... ok
test_done_callback_raises_already_succeeded (test.test_concurrent_futures.FutureTests) ... ok
test_done_callback_with_cancel (test.test_concurrent_futures.FutureTests) ... ok
test_done_callback_with_exception (test.test_concurrent_futures.FutureTests) ... ok
test_done_callback_with_result (test.test_concurrent_futures.FutureTests) ... ok
test_exception_with_success (test.test_concurrent_futures.FutureTests) ... ok
test_exception_with_timeout (test.test_concurrent_futures.FutureTests) ... ok
test_multiple_set_exception (test.test_concurrent_futures.FutureTests) ... ok
test_multiple_set_result (test.test_concurrent_futures.FutureTests) ... ok
test_repr (test.test_concurrent_futures.FutureTests) ... ok
test_result_with_cancel (test.test_concurrent_futures.FutureTests) ... ok
test_result_with_success (test.test_concurrent_futures.FutureTests) ... ok
test_result_with_timeout (test.test_concurrent_futures.FutureTests) ... ok
test_running (test.test_concurrent_futures.FutureTests) ... ok
test_correct_timeout_exception_msg (test.test_concurrent_futures.ProcessPoolForkAsCompletedTest) ... ok
test_duplicate_futures (test.test_concurrent_futures.ProcessPoolForkAsCompletedTest) ... ok
test_free_reference_yielded_future (test.test_concurrent_futures.ProcessPoolForkAsCompletedTest) ... ok
test_no_timeout (test.test_concurrent_futures.ProcessPoolForkAsCompletedTest) ... ok
test_zero_timeout (test.test_concurrent_futures.ProcessPoolForkAsCompletedTest) ... ok
test_crash (test.test_concurrent_futures.ProcessPoolForkExecutorDeadlockTest) ... ok
test_shutdown_deadlock (test.test_concurrent_futures.ProcessPoolForkExecutorDeadlockTest) ... ok
test_shutdown_deadlock_pickle (test.test_concurrent_futures.ProcessPoolForkExecutorDeadlockTest) ... ok
test_initializer (test.test_concurrent_futures.ProcessPoolForkFailingInitializerTest) ... ok
test_initializer (test.test_concurrent_futures.ProcessPoolForkInitializerTest) ... ok
test_free_reference (test.test_concurrent_futures.ProcessPoolForkProcessPoolExecutorTest) ... ok
test_idle_process_reuse_multiple (test.test_concurrent_futures.ProcessPoolForkProcessPoolExecutorTest) ... ok
test_idle_process_reuse_one (test.test_concurrent_futures.ProcessPoolForkProcessPoolExecutorTest) ... ok
test_killed_child (test.test_concurrent_futures.ProcessPoolForkProcessPoolExecutorTest) ... ok
test_map (test.test_concurrent_futures.ProcessPoolForkProcessPoolExecutorTest) ... ok
test_map_chunksize (test.test_concurrent_futures.ProcessPoolForkProcessPoolExecutorTest) ... ok
test_map_exception (test.test_concurrent_futures.ProcessPoolForkProcessPoolExecutorTest) ... ok
test_map_timeout (test.test_concurrent_futures.ProcessPoolForkProcessPoolExecutorTest) ... ok
test_max_workers_negative (test.test_concurrent_futures.ProcessPoolForkProcessPoolExecutorTest) ... ok
test_max_workers_too_large (test.test_concurrent_futures.ProcessPoolForkProcessPoolExecutorTest) ... skipped 'Windows-only process limit'
test_no_stale_references (test.test_concurrent_futures.ProcessPoolForkProcessPoolExecutorTest) ... ok
test_ressources_gced_in_workers (test.test_concurrent_futures.ProcessPoolForkProcessPoolExecutorTest) ... ok
test_saturation (test.test_concurrent_futures.ProcessPoolForkProcessPoolExecutorTest) ... ok
test_shutdown_race_issue12456 (test.test_concurrent_futures.ProcessPoolForkProcessPoolExecutorTest) ... ok
test_submit (test.test_concurrent_futures.ProcessPoolForkProcessPoolExecutorTest) ... ok
test_submit_keyword (test.test_concurrent_futures.ProcessPoolForkProcessPoolExecutorTest) ... ok
test_traceback (test.test_concurrent_futures.ProcessPoolForkProcessPoolExecutorTest) ... ok
test_cancel_futures (test.test_concurrent_futures.ProcessPoolForkProcessPoolShutdownTest) ... ok
test_context_manager_shutdown (test.test_concurrent_futures.ProcessPoolForkProcessPoolShutdownTest) ... ok
test_del_shutdown (test.test_concurrent_futures.ProcessPoolForkProcessPoolShutdownTest) ... ok
test_hang_issue12364 (test.test_concurrent_futures.ProcessPoolForkProcessPoolShutdownTest) ... ok
test_hang_issue39205 (test.test_concurrent_futures.ProcessPoolForkProcessPoolShutdownTest)
shutdown(wait=False) doesn't hang at exit with running futures. ... skipped 'Hangs due to https://bugs.python.org/issue39205'
test_interpreter_shutdown (test.test_concurrent_futures.ProcessPoolForkProcessPoolShutdownTest) ... ok
test_processes_terminate (test.test_concurrent_futures.ProcessPoolForkProcessPoolShutdownTest) ... ok
test_run_after_shutdown (test.test_concurrent_futures.ProcessPoolForkProcessPoolShutdownTest) ... ok
test_shutdown_no_wait (test.test_concurrent_futures.ProcessPoolForkProcessPoolShutdownTest) ... ok
test_submit_after_interpreter_shutdown (test.test_concurrent_futures.ProcessPoolForkProcessPoolShutdownTest) ... ok
test_all_completed (test.test_concurrent_futures.ProcessPoolForkWaitTest) ... ok
test_first_completed (test.test_concurrent_futures.ProcessPoolForkWaitTest) ... ok
test_first_completed_some_already_completed (test.test_concurrent_futures.ProcessPoolForkWaitTest) ... ok
test_first_exception (test.test_concurrent_futures.ProcessPoolForkWaitTest) ... ok
test_first_exception_one_already_failed (test.test_concurrent_futures.ProcessPoolForkWaitTest) ... ok
test_first_exception_some_already_complete (test.test_concurrent_futures.ProcessPoolForkWaitTest) ... ok
test_timeout (test.test_concurrent_futures.ProcessPoolForkWaitTest) ... ok
test_correct_timeout_exception_msg (test.test_concurrent_futures.ProcessPoolForkserverAsCompletedTest) ... ok
test_duplicate_futures (test.test_concurrent_futures.ProcessPoolForkserverAsCompletedTest) ... ok
test_free_reference_yielded_future (test.test_concurrent_futures.ProcessPoolForkserverAsCompletedTest) ... ok
test_no_timeout (test.test_concurrent_futures.ProcessPoolForkserverAsCompletedTest) ... ok
test_zero_timeout (test.test_concurrent_futures.ProcessPoolForkserverAsCompletedTest) ... ok
test_crash (test.test_concurrent_futures.ProcessPoolForkserverExecutorDeadlockTest) ... ok
test_shutdown_deadlock (test.test_concurrent_futures.ProcessPoolForkserverExecutorDeadlockTest) ... ok
test_shutdown_deadlock_pickle (test.test_concurrent_futures.ProcessPoolForkserverExecutorDeadlockTest) ... ok
test_initializer (test.test_concurrent_futures.ProcessPoolForkserverFailingInitializerTest) ... ok
test_initializer (test.test_concurrent_futures.ProcessPoolForkserverInitializerTest) ... ok
test_free_reference (test.test_concurrent_futures.ProcessPoolForkserverProcessPoolExecutorTest) ... ok
test_idle_process_reuse_multiple (test.test_concurrent_futures.ProcessPoolForkserverProcessPoolExecutorTest) ... ok
test_idle_process_reuse_one (test.test_concurrent_futures.ProcessPoolForkserverProcessPoolExecutorTest) ... ok
test_killed_child (test.test_concurrent_futures.ProcessPoolForkserverProcessPoolExecutorTest) ... ok
test_map (test.test_concurrent_futures.ProcessPoolForkserverProcessPoolExecutorTest) ... ok
test_map_chunksize (test.test_concurrent_futures.ProcessPoolForkserverProcessPoolExecutorTest) ... ok
test_map_exception (test.test_concurrent_futures.ProcessPoolForkserverProcessPoolExecutorTest) ... ok
test_map_timeout (test.test_concurrent_futures.ProcessPoolForkserverProcessPoolExecutorTest) ... ok
test_max_workers_negative (test.test_concurrent_futures.ProcessPoolForkserverProcessPoolExecutorTest) ... ok
test_max_workers_too_large (test.test_concurrent_futures.ProcessPoolForkserverProcessPoolExecutorTest) ... skipped 'Windows-only process limit'
test_no_stale_references (test.test_concurrent_futures.ProcessPoolForkserverProcessPoolExecutorTest) ... ok
test_ressources_gced_in_workers (test.test_concurrent_futures.ProcessPoolForkserverProcessPoolExecutorTest) ... ok
test_saturation (test.test_concurrent_futures.ProcessPoolForkserverProcessPoolExecutorTest) ... ok
test_shutdown_race_issue12456 (test.test_concurrent_futures.ProcessPoolForkserverProcessPoolExecutorTest) ... ok
test_submit (test.test_concurrent_futures.ProcessPoolForkserverProcessPoolExecutorTest) ... ok
test_submit_keyword (test.test_concurrent_futures.ProcessPoolForkserverProcessPoolExecutorTest) ... ok
test_traceback (test.test_concurrent_futures.ProcessPoolForkserverProcessPoolExecutorTest) ... ok
test_cancel_futures (test.test_concurrent_futures.ProcessPoolForkserverProcessPoolShutdownTest) ... ok
test_context_manager_shutdown (test.test_concurrent_futures.ProcessPoolForkserverProcessPoolShutdownTest) ... ok
test_del_shutdown (test.test_concurrent_futures.ProcessPoolForkserverProcessPoolShutdownTest) ... ok
test_hang_issue12364 (test.test_concurrent_futures.ProcessPoolForkserverProcessPoolShutdownTest) ... ok
test_hang_issue39205 (test.test_concurrent_futures.ProcessPoolForkserverProcessPoolShutdownTest)
shutdown(wait=False) doesn't hang at exit with running futures. ... skipped 'Hangs due to https://bugs.python.org/issue39205'
test_interpreter_shutdown (test.test_concurrent_futures.ProcessPoolForkserverProcessPoolShutdownTest) ... ok
test_processes_terminate (test.test_concurrent_futures.ProcessPoolForkserverProcessPoolShutdownTest) ... ok
test_run_after_shutdown (test.test_concurrent_futures.ProcessPoolForkserverProcessPoolShutdownTest) ... ok
test_shutdown_no_wait (test.test_concurrent_futures.ProcessPoolForkserverProcessPoolShutdownTest) ... ok
test_submit_after_interpreter_shutdown (test.test_concurrent_futures.ProcessPoolForkserverProcessPoolShutdownTest) ... ok
test_all_completed (test.test_concurrent_futures.ProcessPoolForkserverWaitTest) ... ok
test_first_completed (test.test_concurrent_futures.ProcessPoolForkserverWaitTest) ... ok
test_first_completed_some_already_completed (test.test_concurrent_futures.ProcessPoolForkserverWaitTest) ... ok
test_first_exception (test.test_concurrent_futures.ProcessPoolForkserverWaitTest) ... ok
test_first_exception_one_already_failed (test.test_concurrent_futures.ProcessPoolForkserverWaitTest) ... ok
test_first_exception_some_already_complete (test.test_concurrent_futures.ProcessPoolForkserverWaitTest) ... ok
test_timeout (test.test_concurrent_futures.ProcessPoolForkserverWaitTest) ... ok
test_correct_timeout_exception_msg (test.test_concurrent_futures.ProcessPoolSpawnAsCompletedTest) ... ok
test_duplicate_futures (test.test_concurrent_futures.ProcessPoolSpawnAsCompletedTest) ... ok
test_free_reference_yielded_future (test.test_concurrent_futures.ProcessPoolSpawnAsCompletedTest) ... ok
test_no_timeout (test.test_concurrent_futures.ProcessPoolSpawnAsCompletedTest) ... ok
test_zero_timeout (test.test_concurrent_futures.ProcessPoolSpawnAsCompletedTest) ... ok
test_crash (test.test_concurrent_futures.ProcessPoolSpawnExecutorDeadlockTest) ... ok
test_shutdown_deadlock (test.test_concurrent_futures.ProcessPoolSpawnExecutorDeadlockTest) ... ok
test_shutdown_deadlock_pickle (test.test_concurrent_futures.ProcessPoolSpawnExecutorDeadlockTest) ... ok
test_initializer (test.test_concurrent_futures.ProcessPoolSpawnFailingInitializerTest) ... ok
test_initializer (test.test_concurrent_futures.ProcessPoolSpawnInitializerTest) ... ok
test_free_reference (test.test_concurrent_futures.ProcessPoolSpawnProcessPoolExecutorTest) ... ok
test_idle_process_reuse_multiple (test.test_concurrent_futures.ProcessPoolSpawnProcessPoolExecutorTest) ... ok
test_idle_process_reuse_one (test.test_concurrent_futures.ProcessPoolSpawnProcessPoolExecutorTest) ... ok
test_killed_child (test.test_concurrent_futures.ProcessPoolSpawnProcessPoolExecutorTest) ... ok
test_map (test.test_concurrent_futures.ProcessPoolSpawnProcessPoolExecutorTest) ... ok
test_map_chunksize (test.test_concurrent_futures.ProcessPoolSpawnProcessPoolExecutorTest) ... ok
test_map_exception (test.test_concurrent_futures.ProcessPoolSpawnProcessPoolExecutorTest) ... ok
test_map_timeout (test.test_concurrent_futures.ProcessPoolSpawnProcessPoolExecutorTest) ... ok
test_max_workers_negative (test.test_concurrent_futures.ProcessPoolSpawnProcessPoolExecutorTest) ... ok
test_max_workers_too_large (test.test_concurrent_futures.ProcessPoolSpawnProcessPoolExecutorTest) ... skipped 'Windows-only process limit'
test_no_stale_references (test.test_concurrent_futures.ProcessPoolSpawnProcessPoolExecutorTest) ... ok
test_ressources_gced_in_workers (test.test_concurrent_futures.ProcessPoolSpawnProcessPoolExecutorTest) ... ok
test_saturation (test.test_concurrent_futures.ProcessPoolSpawnProcessPoolExecutorTest) ... ok
test_shutdown_race_issue12456 (test.test_concurrent_futures.ProcessPoolSpawnProcessPoolExecutorTest) ... ok
test_submit (test.test_concurrent_futures.ProcessPoolSpawnProcessPoolExecutorTest) ... ok
test_submit_keyword (test.test_concurrent_futures.ProcessPoolSpawnProcessPoolExecutorTest) ... ok
test_traceback (test.test_concurrent_futures.ProcessPoolSpawnProcessPoolExecutorTest) ... ok
test_cancel_futures (test.test_concurrent_futures.ProcessPoolSpawnProcessPoolShutdownTest) ... ok
test_context_manager_shutdown (test.test_concurrent_futures.ProcessPoolSpawnProcessPoolShutdownTest) ... ok
test_del_shutdown (test.test_concurrent_futures.ProcessPoolSpawnProcessPoolShutdownTest) ... ok
test_hang_issue12364 (test.test_concurrent_futures.ProcessPoolSpawnProcessPoolShutdownTest) ... ok
test_hang_issue39205 (test.test_concurrent_futures.ProcessPoolSpawnProcessPoolShutdownTest)
shutdown(wait=False) doesn't hang at exit with running futures. ... skipped 'Hangs due to https://bugs.python.org/issue39205'
test_interpreter_shutdown (test.test_concurrent_futures.ProcessPoolSpawnProcessPoolShutdownTest) ... ok
test_processes_terminate (test.test_concurrent_futures.ProcessPoolSpawnProcessPoolShutdownTest) ... ok
test_run_after_shutdown (test.test_concurrent_futures.ProcessPoolSpawnProcessPoolShutdownTest) ... ok
test_shutdown_no_wait (test.test_concurrent_futures.ProcessPoolSpawnProcessPoolShutdownTest) ... ok
test_submit_after_interpreter_shutdown (test.test_concurrent_futures.ProcessPoolSpawnProcessPoolShutdownTest) ... ok
test_all_completed (test.test_concurrent_futures.ProcessPoolSpawnWaitTest) ... ok
test_first_completed (test.test_concurrent_futures.ProcessPoolSpawnWaitTest) ... ok
test_first_completed_some_already_completed (test.test_concurrent_futures.ProcessPoolSpawnWaitTest) ... ok
test_first_exception (test.test_concurrent_futures.ProcessPoolSpawnWaitTest) ... ok
test_first_exception_one_already_failed (test.test_concurrent_futures.ProcessPoolSpawnWaitTest) ... ok
test_first_exception_some_already_complete (test.test_concurrent_futures.ProcessPoolSpawnWaitTest) ... ok
test_timeout (test.test_concurrent_futures.ProcessPoolSpawnWaitTest) ... ok
test_correct_timeout_exception_msg (test.test_concurrent_futures.ThreadPoolAsCompletedTest) ... ok
test_duplicate_futures (test.test_concurrent_futures.ThreadPoolAsCompletedTest) ... ok
test_free_reference_yielded_future (test.test_concurrent_futures.ThreadPoolAsCompletedTest) ... ok
test_no_timeout (test.test_concurrent_futures.ThreadPoolAsCompletedTest) ... ok
test_zero_timeout (test.test_concurrent_futures.ThreadPoolAsCompletedTest) ... ok
test_default_workers (test.test_concurrent_futures.ThreadPoolExecutorTest) ... ok
test_free_reference (test.test_concurrent_futures.ThreadPoolExecutorTest) ... ok
test_idle_thread_reuse (test.test_concurrent_futures.ThreadPoolExecutorTest) ... ok
test_map (test.test_concurrent_futures.ThreadPoolExecutorTest) ... ok
test_map_exception (test.test_concurrent_futures.ThreadPoolExecutorTest) ... ok
test_map_submits_without_iteration (test.test_concurrent_futures.ThreadPoolExecutorTest)
Tests verifying issue 11777. ... ok
test_map_timeout (test.test_concurrent_futures.ThreadPoolExecutorTest) ... ok
test_max_workers_negative (test.test_concurrent_futures.ThreadPoolExecutorTest) ... ok
test_no_stale_references (test.test_concurrent_futures.ThreadPoolExecutorTest) ... ok
test_saturation (test.test_concurrent_futures.ThreadPoolExecutorTest) ... ok
test_shutdown_race_issue12456 (test.test_concurrent_futures.ThreadPoolExecutorTest) ... ok
test_submit (test.test_concurrent_futures.ThreadPoolExecutorTest) ... ok
test_submit_keyword (test.test_concurrent_futures.ThreadPoolExecutorTest) ... ok
test_initializer (test.test_concurrent_futures.ThreadPoolFailingInitializerTest) ... ok
test_initializer (test.test_concurrent_futures.ThreadPoolInitializerTest) ... ok
test_cancel_futures (test.test_concurrent_futures.ThreadPoolShutdownTest) ... ok
test_cancel_futures_wait_false (test.test_concurrent_futures.ThreadPoolShutdownTest) ... ok
test_context_manager_shutdown (test.test_concurrent_futures.ThreadPoolShutdownTest) ... ok
test_del_shutdown (test.test_concurrent_futures.ThreadPoolShutdownTest) ... ok
test_hang_issue12364 (test.test_concurrent_futures.ThreadPoolShutdownTest) ... ok
test_hang_issue39205 (test.test_concurrent_futures.ThreadPoolShutdownTest)
shutdown(wait=False) doesn't hang at exit with running futures. ... ok
test_interpreter_shutdown (test.test_concurrent_futures.ThreadPoolShutdownTest) ... ok
test_run_after_shutdown (test.test_concurrent_futures.ThreadPoolShutdownTest) ... ok
test_shutdown_no_wait (test.test_concurrent_futures.ThreadPoolShutdownTest) ... ok
test_submit_after_interpreter_shutdown (test.test_concurrent_futures.ThreadPoolShutdownTest) ... ok
test_thread_names_assigned (test.test_concurrent_futures.ThreadPoolShutdownTest) ... ok
test_thread_names_default (test.test_concurrent_futures.ThreadPoolShutdownTest) ... ok
test_threads_terminate (test.test_concurrent_futures.ThreadPoolShutdownTest) ... ok
test_all_completed (test.test_concurrent_futures.ThreadPoolWaitTests) ... ok
test_first_completed (test.test_concurrent_futures.ThreadPoolWaitTests) ... ok
test_first_completed_some_already_completed (test.test_concurrent_futures.ThreadPoolWaitTests) ... ok
test_first_exception (test.test_concurrent_futures.ThreadPoolWaitTests) ... ok
test_first_exception_one_already_failed (test.test_concurrent_futures.ThreadPoolWaitTests) ... ok
test_first_exception_some_already_complete (test.test_concurrent_futures.ThreadPoolWaitTests) ... ok
test_pending_calls_race (test.test_concurrent_futures.ThreadPoolWaitTests) ... ok
test_timeout (test.test_concurrent_futures.ThreadPoolWaitTests) ... ok

----------------------------------------------------------------------

Ran 193 tests in 188.236s

OK (skipped=6)
make: *** [buildbottest] Error 3

miss-islington added a commit that referenced this pull request Apr 22, 2020
@miss-islington @asottile
bpo-40260: Remove unnecessary newline in compile() call (GH-19641)
fc45cb4 
Because some people subclass this class and call undocumented methods, and we don't want to break them.
(cherry picked from commit 39652cd)

Co-authored-by: Anthony Sottile <asottile@umich.edu>
@asottile
asottile deleted the remove_unnecessary_newline branch July 31, 2020 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@asottile @zooba @miss-islington @bedevere-bot @the-knights-who-say-ni