Skip to content

bpo-40327: Improve atomicity speed and memory efficiency of the items() loop #19628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rhettinger merged 1 commit into from
Apr 21, 2020
Merged

bpo-40327: Improve atomicity speed and memory efficiency of the items() loop #19628

rhettinger merged 1 commit into from
Apr 21, 2020

Conversation

@rhettinger
Copy link
Contributor

@rhettinger rhettinger commented Apr 20, 2020 •
edited by bedevere-bot
Loading

This isn't a complete solution to the OP's problem, but it does mitigate the race condition risk, and it also improves memory efficiency and speed.

https://bugs.python.org/issue40327

@serhiy-storchaka serhiy-storchaka added the type-bug An unexpected behavior, bug, or error label Apr 21, 2020
@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Apr 21, 2020

👍

@rhettinger rhettinger merged commit 75bedbe into python:master Apr 21, 2020
@miss-islington
Copy link
Contributor

miss-islington commented Apr 21, 2020

Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 21, 2020
@rhettinger @miss-islington
bpo-40327: Improve atomicity, speed, and memory efficiency of the ite…
0e08cb5 
…ms() loop (pythonGH-19628)

(cherry picked from commit 75bedbe)

Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>
@bedevere-bot
Copy link

bedevere-bot commented Apr 21, 2020

GH-19640 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request May 22, 2020
@miss-islington @rhettinger
bpo-40327: Improve atomicity, speed, and memory efficiency of the ite…
16d0781 
…ms() loop (GH-19628)

(cherry picked from commit 75bedbe)

Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

Assignees

No one assigned

Labels

performance Performance or resource usage skip news type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rhettinger @serhiy-storchaka @miss-islington @bedevere-bot @the-knights-who-say-ni