bpo-40335: Correctly handle multi-line strings in tokenize error scenarios#19619
Merged
pablogsal merged 2 commits intopython:masterfrom Apr 21, 2020
Merged
bpo-40335: Correctly handle multi-line strings in tokenize error scenarios#19619pablogsal merged 2 commits intopython:masterfrom
pablogsal merged 2 commits intopython:masterfrom
Conversation
Member
Author
|
CC: @asottile Can you check if this PR runs correctly with your test suite? |
Contributor
|
yep pyflakes is now passing (with a minor patch, but this patch is expected): $ git diff
diff --git a/pyflakes/test/test_api.py b/pyflakes/test/test_api.py
index 128aa69..b579ac8 100644
--- a/pyflakes/test/test_api.py
+++ b/pyflakes/test/test_api.py
@@ -449,6 +449,8 @@ def baz():
with self.makeTempFile(source) as sourcePath:
if PYPY:
message = 'end of file (EOF) while scanning triple-quoted string literal'
+ elif sys.version_info >= (3, 9):
+ message = 'invalid string prefix'
else:
message = 'invalid syntax'
|
Member
Author
Yeah, that was on purpose 😉 |
Member
|
Thanks, @pablogsal, for the fix! 😃 |
gvanrossum
approved these changes
Apr 20, 2020
Member
gvanrossum
left a comment
gvanrossum
left a comment
There was a problem hiding this comment.
Weak approve: I don't feel super confident with the ins and outs of this code, but if the tests pass, I feel it's fine.
Co-Authored-By: Guido van Rossum <gvanrossum@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue40335