Skip to content

gdbinit: Use proper define syntax#19557

Merged
miss-islington merged 1 commit intopython:masterfrom
The-Compiler:patch-1
Apr 23, 2020
Merged

gdbinit: Use proper define syntax#19557
miss-islington merged 1 commit intopython:masterfrom
The-Compiler:patch-1

Conversation

@The-Compiler
Copy link
Copy Markdown
Contributor

@The-Compiler The-Compiler commented Apr 16, 2020 •
edited by miss-islington
Loading

Using def rather than define results in:

Ambiguous command "def pu": define, define-prefix.

Automerge-Triggered-By: @csabella

@The-Compiler
gdbinit: Use proper define syntax
5857556 
Using `def` rather than `define` results in:

    Ambiguous command "def pu": define, define-prefix.
csabella
csabella approved these changes Apr 23, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@csabella csabella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@miss-islington miss-islington merged commit 1221135 into python:master Apr 23, 2020
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Apr 23, 2020

Thanks @The-Compiler for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 23, 2020
@The-Compiler @miss-islington
gdbinit: Use proper define syntax (pythonGH-19557)
47669da 
Using `def` rather than `define` results in:

    Ambiguous command "def pu": define, define-prefix.

Automerge-Triggered-By: @csabella
(cherry picked from commit 1221135)

Co-authored-by: Florian Bruhin <me@the-compiler.org>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Apr 23, 2020

GH-19676 is a backport of this pull request to the 3.8 branch.

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Apr 23, 2020

Sorry, @The-Compiler, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 1221135289306333d11db25ab20cbbd21ceec630 3.7

@miss-islington miss-islington self-assigned this Apr 23, 2020
miss-islington added a commit that referenced this pull request Apr 23, 2020
@miss-islington @The-Compiler
gdbinit: Use proper define syntax (GH-19557)
714aa83 
Using `def` rather than `define` results in:

    Ambiguous command "def pu": define, define-prefix.

Automerge-Triggered-By: @csabella
(cherry picked from commit 1221135)

Co-authored-by: Florian Bruhin <me@the-compiler.org>
@The-Compiler
Copy link
Copy Markdown
Contributor Author

The-Compiler commented Apr 23, 2020 •
edited
Loading

Manual cherry-pick to 3.7: #19678

edit: Hah, faster than the bot 😉

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Apr 23, 2020

GH-19678 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit that referenced this pull request Apr 23, 2020
@The-Compiler
[3.7] gdbinit: Use proper define syntax (GH-19557) (GH-19678)
e1072d6 
Using `def` rather than `define` results in:

    Ambiguous command "def pu": define, define-prefix.

Automerge-Triggered-By: @csabella.
(cherry picked from commit 1221135)

Co-authored-by: Florian Bruhin <me@the-compiler.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@csabella csabella csabella approved these changes

Assignees

@miss-islington miss-islington

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@The-Compiler @miss-islington @bedevere-bot @csabella @the-knights-who-say-ni