bpo-40260: fix API regression with file_info mode field#19549
Closed
barry-scott wants to merge 1 commit into
Closed
bpo-40260: fix API regression with file_info mode field#19549barry-scott wants to merge 1 commit into
barry-scott wants to merge 1 commit into
Conversation
debian uses modulefinder by subclassing ModuleFinder and implementing load_module(). They depend on the file_info tuple having 3 elements. Restore the mode to the file_info tuple. Add test case to detect a regression on this API.
Member
|
https://bugs.python.org/issue40260 is closed. What is the status of this PR? |
Contributor
Author
|
On 11 Apr 2022, at 23:56, Irit Katriel ***@***.***> wrote:
https://bugs.python.org/issue40260 is closed. What is the status of this PR?
This is all done. The pr was merged.
Barry
… —
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
debian uses modulefinder by subclassing ModuleFinder and
implementing load_module().
They depend on the file_info tuple having 3 elements.
Restore the mode to the file_info tuple.
Add test case to detect a regression on this API.
https://bugs.python.org/issue40260