Skip to content

bpo-40225: Don't raise an exception on normal return from generator.#19473

Merged
markshannon merged 1 commit into
python:masterfrom
markshannon:dont-raise-on-generate-return
Jun 4, 2020
Merged

bpo-40225: Don't raise an exception on normal return from generator.#19473
markshannon merged 1 commit into
python:masterfrom
markshannon:dont-raise-on-generate-return

Conversation

@markshannon

@markshannon markshannon commented Apr 11, 2020

Copy link
Copy Markdown
Member

Reducing runtime on the example program in bpo-40225 on my machine from 2.427s to 0.142s. (With a non PGO, LTO build).

https://bugs.python.org/issue40225

@markshannon markshannon added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 11, 2020
@markshannon
markshannon requested a review from 1st1 as a code owner April 11, 2020 12:09
@bedevere-bot

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @markshannon for commit cec3fae987bfa8358da66674c2008b1828cdb5a0 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 11, 2020
@corona10

Copy link
Copy Markdown
Member

FYI, the current ref leak is a known issue.

@markshannon markshannon added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 22, 2020
@bedevere-bot

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @markshannon for commit cec3fae987bfa8358da66674c2008b1828cdb5a0 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 22, 2020
@markshannon

Copy link
Copy Markdown
Member Author

Re-running on buildbots. If the failures are the same as master, then I'll merge.

@markshannon

Copy link
Copy Markdown
Member Author

I don't think this introduces a leak, but the stdout of the refleaks test differs, so I'm going to hold off merging until the buildbots are green.

@markshannon
markshannon force-pushed the dont-raise-on-generate-return branch from cec3fae to 232a0f7 Compare June 1, 2020 16:06
@markshannon markshannon added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 3, 2020
@bedevere-bot

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @markshannon for commit 232a0f7 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 3, 2020
@markshannon

Copy link
Copy Markdown
Member Author

The windows buildbot failure seems totally unrelated and the buildbot seems unstable, so merging.

@markshannon
markshannon merged commit 50a48da into python:master Jun 4, 2020
@markshannon
markshannon deleted the dont-raise-on-generate-return branch October 19, 2020 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants