bpo-35212: fix col_offset in f-strings#19398
bpo-35212: fix col_offset in f-strings#19398matanagasauce wants to merge 3 commits intopython:mainfrom
Conversation
|
Hi @yangyangxcf. Unfortunately, the |
|
Ping, @yangyangxcf, @pablogsal? |
This PR still needs to be rebased as per #19398 (comment). As I mentioned, I am fine to take it over if @yangyangxcf is ok with that |
|
Let's give this another couple of weeks then, @pablogsal? |
|
I believe this was fixed by #27729. The reported issues seem similar to what is fixed there. Note that on Python 3.10 this now works as expected: >>> ast.parse("f'{a}'").body[0].value.values[0].value.col_offset
3
>>> ast.parse("f'{a:b}'").body[0].value.values[0].value.col_offset
3The other issue in the original report is resolved as well. Edit: @ericvsmith Gentle ping since you closed the bpo and might want to close this PR as well 😄 |
|
@DanielNoord :Thanks for the reminder! |
https://bugs.python.org/issue35212