Skip to content

bpo-40067 : Improve error messages for multiple star expressions in assignment#19168

Merged
pablogsal merged 11 commits into
python:masterfrom
furkanonder:bpo-40067
Mar 26, 2020
Merged

bpo-40067 : Improve error messages for multiple star expressions in assignment#19168
pablogsal merged 11 commits into
python:masterfrom
furkanonder:bpo-40067

Conversation

@furkanonder

@furkanonder furkanonder commented Mar 25, 2020

Copy link
Copy Markdown
Contributor

@furkanonder furkanonder changed the title Improve error messages for multiple star expressions in assignment bpo-40067 : Improve error messages for multiple star expressions in assignment Mar 25, 2020
Comment thread Lib/test/test_unpack_ex.py Outdated
Comment thread Misc/NEWS.d/next/Core and Builtins/2020-03-25-20-34-01.bpo-40067.0bFda2.rst Outdated
….0bFda2.rst

Co-Authored-By: Batuhan Taşkaya <isidentical@gmail.com>
Comment thread Python/compile.c Outdated
Comment thread Misc/NEWS.d/next/Core and Builtins/2020-03-25-20-34-01.bpo-40067.0bFda2.rst Outdated
@pablogsal

Copy link
Copy Markdown
Member

Thanks for your first contribution @furkanonder ! If you wish, you can also add yourself to the https://github.com/python/cpython/blob/master/Misc/ACKS file.

@pablogsal

Copy link
Copy Markdown
Member

Many thanks also @isidentical for the review :) 🎉

@furkanonder

Copy link
Copy Markdown
Contributor Author

Thanks for your first contribution @furkanonder ! If you wish, you can also add yourself to the https://github.com/python/cpython/blob/master/Misc/ACKS file.

Thank you very much for your review :) I added myself to ASK file.
Can you review again the PR?

@furkanonder
furkanonder requested a review from pablogsal March 25, 2020 22:12
Comment thread Misc/NEWS.d/next/Core and Builtins/2020-03-25-20-34-01.bpo-40067.0bFda2.rst Outdated

@pablogsal pablogsal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pablogsal
pablogsal merged commit cb6534e into python:master Mar 26, 2020
isidentical added a commit to isidentical/parso that referenced this pull request May 21, 2020
In Python3.9, the message "two starred expression in ..." changed
to "multiple starred expression in ...", with python/cpython#19168
davidhalter pushed a commit to davidhalter/parso that referenced this pull request May 21, 2020
In Python3.9, the message "two starred expression in ..." changed
to "multiple starred expression in ...", with python/cpython#19168
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants