bpo-39830: Add zipfile.Path to __all__#19115
Merged
Merged
Conversation
tirkarthi
approved these changes
Mar 23, 2020
tirkarthi
left a comment
tirkarthi
left a comment
Member
There was a problem hiding this comment.
LGTM. Thanks @ZackerySpytz .
jaraco
approved these changes
Mar 23, 2020
jaraco
left a comment
jaraco
left a comment
Member
There was a problem hiding this comment.
LGTM. Only concern - should this be backported to Python 3.8? My instinct is yes.
Contributor
|
Thanks @ZackerySpytz for the PR, and @jaraco for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
|
GH-19116 is a backport of this pull request to the 3.8 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 23, 2020
(cherry picked from commit 9a81ab1) Co-authored-by: Zackery Spytz <zspytz@gmail.com>
Member
|
It might cause problem for * imports since Path is already present in pathlib. I am not sure of the policy to change |
Member
|
Yesterday, I learned that |
jaraco
pushed a commit
that referenced
this pull request
May 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue39830