bpo-39966: Fix wrapped objects exception mockunittest#19102
Closed
amiremohamadi wants to merge 7 commits into
Closed
bpo-39966: Fix wrapped objects exception mockunittest#19102amiremohamadi wants to merge 7 commits into
amiremohamadi wants to merge 7 commits into
Conversation
brandtbucher
requested changes
Mar 25, 2020
brandtbucher
left a comment
brandtbucher
left a comment
Member
There was a problem hiding this comment.
Thanks @amiremohamadi, this looks good.
I just think we can simplify the tests and clean up the NEWS entry a bit:
Member
|
The CI failure is a separate bug, and can be ignored. |
Co-Authored-By: Brandt Bucher <brandtbucher@gmail.com>
Co-Authored-By: Brandt Bucher <brandtbucher@gmail.com>
Co-Authored-By: Brandt Bucher <brandtbucher@gmail.com>
Member
|
Closing this as the change was reverted. Please refer to the bug for discussion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the wrapped value of magic methods will be used when present or falls back to the default value.
@brandtbucher
https://bugs.python.org/issue39966