Skip to content

bpo-21760: fix __file__ description#19097

Merged
miss-islington merged 11 commits into
python:mainfrom
furkanonder:bpo-21760
Jun 9, 2021
Merged

bpo-21760: fix __file__ description#19097
miss-islington merged 11 commits into
python:mainfrom
furkanonder:bpo-21760

Conversation

@furkanonder

@furkanonder furkanonder commented Mar 21, 2020 •
edited by miss-islington
Loading

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue21760

Automerge-Triggered-By: GH:ericsnowcurrently

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Mar 21, 2020
@furkanonder furkanonder changed the title fix __file__ description bpo-21760: fix __file__ description Mar 21, 2020
isidentical
isidentical reviewed Mar 21, 2020
View reviewed changes
Comment thread Doc/reference/import.rst Outdated
@furkanonder @isidentical
Update Doc/reference/import.rst
e03d03a 
Co-Authored-By: Batuhan Taşkaya <isidentical@gmail.com>
isidentical
isidentical reviewed Mar 21, 2020
View reviewed changes
Comment thread Doc/reference/import.rst Outdated
@furkanonder @isidentical
Update Doc/reference/import.rst
03fe5e3 
Co-Authored-By: Batuhan Taşkaya <isidentical@gmail.com>
@furkanonder
furkanonder requested a review from isidentical March 21, 2020 19:47
isidentical
isidentical reviewed Mar 23, 2020
View reviewed changes
Comment thread Doc/reference/import.rst Outdated
@furkanonder @isidentical
Update Doc/reference/import.rst
15c5cb4 
Co-Authored-By: Batuhan Taşkaya <isidentical@gmail.com>
isidentical
isidentical approved these changes Mar 23, 2020
View reviewed changes

@isidentical isidentical left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@verhovsky

verhovsky commented Mar 24, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

__file__ and __cached__ are documented together. Here, you're splitting the section into two and the docs for __cached__ make less sense now.

@furkanonder

furkanonder commented Apr 7, 2020

Copy link
Copy Markdown
Contributor Author

__file__ and __cached__ are documented together. Here, you're splitting the section into two and the docs for __cached__ make less sense now.

@verhovsky I made some changes. Can you review it again?

facundobatista
facundobatista requested changes Sep 2, 2020
View reviewed changes

@facundobatista facundobatista left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work here! The hep text needs to be improved, see inline comment.

Comment thread Doc/reference/import.rst Outdated
@bedevere-bot

bedevere-bot commented Sep 2, 2020

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

facundobatista
facundobatista approved these changes Sep 13, 2020
View reviewed changes

@facundobatista facundobatista left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, thanks!

@iritkatriel

iritkatriel commented May 22, 2021

Copy link
Copy Markdown
Member

This is "awaiting merge" since Sept 2020. Any reason why it should not be merged?

ericsnowcurrently
ericsnowcurrently approved these changes Jun 9, 2021
View reviewed changes

@ericsnowcurrently ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miss-islington
miss-islington merged commit 878d7e4 into python:main Jun 9, 2021
@ericsnowcurrently

ericsnowcurrently commented Jun 9, 2021

Copy link
Copy Markdown
Member

Thanks, @furkanonder!

@furkanonder

furkanonder commented Jun 9, 2021

Copy link
Copy Markdown
Contributor Author

Thanks, @furkanonder!

You are welcome!

@ericsnowcurrently ericsnowcurrently mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facundobatista facundobatista facundobatista approved these changes
@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes
@isidentical isidentical isidentical approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@furkanonder @verhovsky @bedevere-bot @iritkatriel @ericsnowcurrently @facundobatista @isidentical @the-knights-who-say-ni @miss-islington