bpo-26067: Do not fail test_shutil / chown when gid/uid cannot be resolved#19032
Conversation
There is no guarantee that the users primary uid or gid can be resolved in the unix group/account databases. Skip the last part of the chown test if we cannot resolve the gid or uid to a name.
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
| # In case the uid/gid cannot be resolved. | ||
| user = None | ||
| group = None | ||
| if user is not None and group is not None: |
There was a problem hiding this comment.
You could do try/except KeyError: pass/else here instead of doing the assignments and None checks.
There was a problem hiding this comment.
Just wanted to keep the try/except scope as small as possible in case some of the other commands raise. Anyway will change.
There was a problem hiding this comment.
Oops, just realized what you meant here, re-submitted.
| @@ -0,0 +1 @@ | |||
| - Do not fail test_shutil test_chown test when uid or gid of user cannot be resolved to a name. No newline at end of file | |||
There was a problem hiding this comment.
| - Do not fail test_shutil test_chown test when uid or gid of user cannot be resolved to a name. | |
| Do not fail test_shutil test_chown test when uid or gid of user cannot be resolved to a name. |
|
@DinoV: Please replace |
5 participants
There is no guarantee that the users primary uid or gid can be resolved
in the unix group/account databases. Skip the last part of the chown
test if we cannot resolve the gid or uid to a name.
https://bugs.python.org/issue26067