Skip to content

bpo-37207: Use PEP 590 vectorcall to speed up set() #19019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 2 commits into from
Mar 16, 2020
Merged

bpo-37207: Use PEP 590 vectorcall to speed up set() #19019

vstinner merged 2 commits into from
Mar 16, 2020

Conversation

@corona10
Copy link
Member

@corona10 corona10 commented Mar 15, 2020 •
edited by bedevere-bot
Loading

PEP 590

./python.exe -m pyperf timeit "set([1, 2, 3, 4, 5])"
.....................
Mean +- std dev: 2.00 us +- 0.04 us

./python.exe -m pyperf timeit "set((1, 2, 3, 4, 5))"
.....................
Mean +- std dev: 1.65 us +- 0.04 us

./python.exe -m pyperf timeit "set()"
.....................
Mean +- std dev: 448 ns +- 15 ns

Master

./python.exe -m pyperf timeit "set([1, 2, 3, 4, 5])"
.....................
Mean +- std dev: 2.30 us +- 0.04 us

./python.exe -m pyperf timeit "set((1, 2, 3, 4, 5))"
.....................
Mean +- std dev: 1.84 us +- 0.05 us

./python.exe -m pyperf timeit "set()"
.....................
Mean +- std dev: 528 ns +- 16 ns

https://bugs.python.org/issue37207

@corona10 corona10 requested a review from rhettinger as a code owner March 15, 2020 14:27
@corona10 corona10 requested a review from vstinner March 15, 2020 14:28
corona10
corona10 commented Mar 15, 2020
View reviewed changes
vstinner
vstinner reviewed Mar 16, 2020
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When doing benchmarks, you can use two Python binaries and use pyperf timeit --compare-to=REF_PYTHON_BINARY (...). It checks that the difference is significant.
https://pyperf.readthedocs.io/en/latest/cli.html#pyperf-timeit

Or you can store results in JSON files and use pyperf compare_to command.

@vstinner
Copy link
Member

vstinner commented Mar 16, 2020

I merged PR #18980, please rebase your PR on top of master and modify your PR to use _PyArg_NoKwnames().

vstinner
vstinner approved these changes Mar 16, 2020
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vstinner
Copy link
Member

vstinner commented Mar 16, 2020

IMHO it's worth it to add a few lines of C code to make tuple() and set() constructors faster.

@corona10
Copy link
Member Author

corona10 commented Mar 16, 2020

IMHO it's worth it to add a few lines of C code to make tuple() and set() constructors faster

Yeah, I think the PEP 590 implemented very well to bring performance enhancement very easily.

@vstinner
Copy link
Member

vstinner commented Mar 16, 2020

Yeah, I think the PEP 590 implemented very well to bring performance enhancement very easily.

What I mean is that vectorcall should not be used for everything. But set() and tuple() are very commonly used, so here it's worth it.

@vstinner vstinner merged commit 6ff79f6 into python:master Mar 16, 2020
@corona10 corona10 deleted the bpo-37207-set branch March 18, 2020 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

@rhettinger rhettinger Awaiting requested review from rhettinger

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@corona10 @vstinner @the-knights-who-say-ni @bedevere-bot