bpo-30534: Fix error messages when pass keyword arguments #1901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to functions implemented in C that don't support this.
vstinner
approved these changes
Jun 1, 2017
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM, I also like included cleanup changes ;-)
On the issue, I requested unit tests. But I also proposed to change the error message, so we write tests later, when we agree on what should be done.
vstinner
reviewed
Jun 6, 2017
|
|
||
| def test_varargs0_kw(self): | ||
| self.assertRaises(TypeError, {}.__contains__, x=2) | ||
|
|
Member
There was a problem hiding this comment.
You may keep this test for other Python implementations. (This test doesn't check the error message.)
Member
Author
There was a problem hiding this comment.
This is a duplicate of the following test.
Lib/test/test_itertools.py
Outdated
| except TypeError as err: | ||
| # we expect type errors because of wrong argument count | ||
| self.assertNotIn("does not take keyword arguments", err.args[0]) | ||
| print(repr(err)) |
Objects/call.c
Outdated
| break; | ||
|
|
||
| case METH_VARARGS: | ||
| if (!(flags & METH_KEYWORDS) && nkwargs) { |
Member
There was a problem hiding this comment.
Is "!(flags & METH_KEYWORDS)" still needed?
Member
Author
There was a problem hiding this comment.
Not needed. Removed.
Member
Author
|
Thank you for your review @Haypo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to functions implemented in C that don't support this.