Skip to content

bpo-39930: Convert error to warning for more silent failure#18921

Merged
zooba merged 2 commits intopython:masterfrom
zooba:bpo-39330
Mar 11, 2020
Merged

bpo-39930: Convert error to warning for more silent failure#18921
zooba merged 2 commits intopython:masterfrom
zooba:bpo-39330

Conversation

@zooba
Copy link
Copy Markdown
Member

@zooba zooba commented Mar 11, 2020 •
edited
Loading

@zooba zooba requested a review from a team as a code owner March 11, 2020 13:45
@zooba zooba changed the title bpo-39330: Convert error to warning for more silent failure bpo-39930: Convert error to warning for more silent failure Mar 11, 2020
@zooba zooba added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 11, 2020
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Mar 11, 2020

🤖 New build scheduled with the buildbot fleet by @zooba for commit 45fcf30 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 11, 2020
@zooba
Copy link
Copy Markdown
Member Author

zooba commented Mar 11, 2020

Enough buildbots have passed that I'm happy with this. The Win7 ones are known to be broken on master.

@zooba zooba merged commit fde44ae into python:master Mar 11, 2020
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Mar 11, 2020

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@zooba zooba deleted the bpo-39330 branch March 11, 2020 14:12
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Mar 11, 2020

Sorry @zooba, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker fde44ae6d08d3df79554155b1cf079e73a8fabdd 3.8

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Mar 11, 2020

GH-18922 is a backport of this pull request to the 3.7 branch.

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Mar 11, 2020

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Mar 11, 2020

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 11, 2020
@zooba @miss-islington
bpo-39930: Convert error to warning for more silent failure (pythonGH…
e507fae 
…-18921)

Makes it an error to create a layout without vcruntime DLL
(cherry picked from commit fde44ae)

Co-authored-by: Steve Dower <steve.dower@python.org>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Mar 11, 2020

GH-18923 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 11, 2020
@zooba @miss-islington
bpo-39930: Convert error to warning for more silent failure (pythonGH…
8a4c6c6 
…-18921)

Makes it an error to create a layout without vcruntime DLL
(cherry picked from commit fde44ae)

Co-authored-by: Steve Dower <steve.dower@python.org>
miss-islington added a commit that referenced this pull request Mar 11, 2020
@miss-islington @zooba
bpo-39930: Convert error to warning for more silent failure (GH-18921)
3136f6f 
Makes it an error to create a layout without vcruntime DLL
(cherry picked from commit fde44ae)

Co-authored-by: Steve Dower <steve.dower@python.org>
miss-islington added a commit that referenced this pull request Mar 11, 2020
@miss-islington @zooba
bpo-39930: Convert error to warning for more silent failure (GH-18921)
17571c5 
Makes it an error to create a layout without vcruntime DLL
(cherry picked from commit fde44ae)

Co-authored-by: Steve Dower <steve.dower@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@zooba zooba

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zooba @bedevere-bot @miss-islington @the-knights-who-say-ni