Skip to content

bpo-38643: Raise SystemError instead of crashing when PyNumber_ToBase is called with invalid base.#18863

Merged
serhiy-storchaka merged 1 commit into
python:masterfrom
serhiy-storchaka:PyNumber_ToBase-arg-check
Mar 9, 2020
Merged

bpo-38643: Raise SystemError instead of crashing when PyNumber_ToBase is called with invalid base.#18863
serhiy-storchaka merged 1 commit into
python:masterfrom
serhiy-storchaka:PyNumber_ToBase-arg-check

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Mar 8, 2020

Copy link
Copy Markdown
Member

@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@serhiy-storchaka
serhiy-storchaka deleted the PyNumber_ToBase-arg-check branch March 9, 2020 18:03
@miss-islington

Copy link
Copy Markdown
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker e5ccc94bbb153431698b2391df625e8d47a93276 3.8

@miss-islington

Copy link
Copy Markdown
Contributor

Sorry @serhiy-storchaka, I had trouble checking out the 3.7 backport branch.
Please backport using cherry_picker on command line.
cherry_picker e5ccc94bbb153431698b2391df625e8d47a93276 3.7

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Mar 12, 2020
…ToBase is called with invalid base. (pythonGH-18863).

(cherry picked from commit e5ccc94)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot

Copy link
Copy Markdown

GH-18954 is a backport of this pull request to the 3.8 branch.

serhiy-storchaka added a commit that referenced this pull request Mar 12, 2020
…ToBase is called with invalid base. (GH-18863). (GH-18954)

(cherry picked from commit e5ccc94)
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Mar 12, 2020
…ToBase is called with invalid base. (pythonGH-18863).

(cherry picked from commit e5ccc94)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull request Mar 12, 2020
…ToBase is called with invalid base. (GH-18863). (GH-18955)

(cherry picked from commit e5ccc94)
@serhiy-storchaka serhiy-storchaka removed their assignment Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants