bpo-39674: Revert "bpo-37330: open() no longer accept 'U' in file mode (GH-16959)" #18767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@tirkarthi @serhiy-storchaka: You approved PR #16959. Would you mind to review this revert? See https://bugs.python.org/issue39674 for the rationale. |
tirkarthi
approved these changes
Mar 4, 2020
Member
tirkarthi
left a comment
tirkarthi
left a comment
There was a problem hiding this comment.
LGTM since it seems to be a straightforward revert of the commit. Thanks Victor.
Member
Author
|
Thanks for the review @tirkarthi ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit e471e72.
The mode will be removed from Python 3.10.
https://bugs.python.org/issue39674