bpo-39778: Add clarification about tp_traverse and ownership #18754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablogsal
added
needs backport to 3.7
skip news
and removed
CLA signed
awaiting core review
docs
Member
Author
|
Feel free to use the new multi-line suggestion feature of GitHub if you wish to edit the message :) |
tim-one
approved these changes
Mar 3, 2020
Member
tim-one
left a comment
tim-one
left a comment
There was a problem hiding this comment.
Made one minor grammar repair - other than that, ship it! 😃
Co-Authored-By: Tim Peters <tim.peters@gmail.com>
Contributor
|
@pablogsal: Status check is done, and it's a success ✅ . |
Contributor
|
Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 3, 2020
…H-18754) Automerge-Triggered-By: @pablogsal (cherry picked from commit 6df421f) Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
|
GH-18762 is a backport of this pull request to the 3.8 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 3, 2020
…H-18754) Automerge-Triggered-By: @pablogsal (cherry picked from commit 6df421f) Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
|
GH-18763 is a backport of this pull request to the 3.7 branch. |
miss-islington
added a commit
that referenced
this pull request
Mar 3, 2020
Automerge-Triggered-By: @pablogsal (cherry picked from commit 6df421f) Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
miss-islington
added a commit
that referenced
this pull request
Mar 3, 2020
Automerge-Triggered-By: @pablogsal (cherry picked from commit 6df421f) Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue39778
Automerge-Triggered-By: @pablogsal