Skip to content

[3.8] bpo-39776: Lock ++interp->tstate_next_unique_id. (GH-18746) #18752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skrah merged 1 commit into from
Mar 3, 2020
Merged

[3.8] bpo-39776: Lock ++interp->tstate_next_unique_id. (GH-18746) #18752

skrah merged 1 commit into from
Mar 3, 2020

Conversation

@skrah
Copy link
Contributor

@skrah skrah commented Mar 2, 2020 •
edited by bedevere-bot
Loading

bpo-39776: Lock ++interp->tstate_next_unique_id. (GH-18746) (#18746)
f89a5ff 
  - Threads created by PyGILState_Ensure() could have a duplicate tstate->id.

(cherry picked from commit b3b9ade)
@bedevere-bot bedevere-bot mentioned this pull request Mar 2, 2020
Merged
@codecov
Copy link

codecov bot commented Mar 2, 2020 •
edited
Loading

Codecov Report

Merging #18752 into 3.8 will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              3.8   #18752      +/-   ##
==========================================
+ Coverage   82.09%   82.10%   +0.01%     
==========================================
  Files        1919     1918       -1     
  Lines      582315   576960    -5355     
  Branches    43743    43743              
==========================================
- Hits       478061   473736    -4325     
+ Misses      94683    93651    -1032     
- Partials     9571     9573       +2
Impacted Files Coverage Δ
Lib/distutils/tests/test_bdist_rpm.py 30.00% <0.00%> (-65.00%) ⬇️
Lib/distutils/command/bdist_rpm.py 7.63% <0.00%> (-56.88%) ⬇️
Modules/_decimal/libmpdec/umodarith.h 80.76% <0.00%> (-19.24%) ⬇️
Lib/test/test_urllib2net.py 76.68% <0.00%> (-13.99%) ⬇️
Lib/test/test_smtpnet.py 78.57% <0.00%> (-7.15%) ⬇️
Lib/ftplib.py 63.72% <0.00%> (-6.08%) ⬇️
Lib/test/test_ftplib.py 87.08% <0.00%> (-4.74%) ⬇️
Tools/scripts/db2pickle.py 17.82% <0.00%> (-3.97%) ⬇️
Lib/test/test_socket.py 72.14% <0.00%> (-3.89%) ⬇️
Tools/scripts/pickle2db.py 16.98% <0.00%> (-3.78%) ⬇️
... and 328 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ad9982...f89a5ff. Read the comment docs.

@bedevere-bot
Copy link

bedevere-bot commented Mar 3, 2020

@skrah: Please replace # with GH- in the commit message next time. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@skrah @bedevere-bot @the-knights-who-say-ni