Skip to content

bpo-39831: Fix a reference leak in PyErr_WarnEx(). #18750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
serhiy-storchaka merged 1 commit into from
Mar 2, 2020
Merged

bpo-39831: Fix a reference leak in PyErr_WarnEx(). #18750

serhiy-storchaka merged 1 commit into from
Mar 2, 2020

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Mar 2, 2020 •
edited by bedevere-bot
Loading

@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error skip news needs backport to 3.7 labels Mar 2, 2020
@serhiy-storchaka serhiy-storchaka merged commit 2d2f855 into python:master Mar 2, 2020
@miss-islington
Copy link
Contributor

miss-islington commented Mar 2, 2020

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Mar 2, 2020

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

@serhiy-storchaka serhiy-storchaka deleted the warnings-leak branch March 2, 2020 20:05
@miss-islington
Copy link
Contributor

miss-islington commented Mar 2, 2020

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 2d2f85517f8216146a2f888d1ad4d765b3be2339 3.7

sthagen added a commit to sthagen/python-cpython that referenced this pull request Mar 2, 2020
@sthagen
Merge pull request #295 from python/master
02a159f 
bpo-39831: Fix a reference leak in PyErr_WarnEx(). (pythonGH-18750)
@miss-islington
Copy link
Contributor

miss-islington commented Mar 3, 2020

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Mar 3, 2020

Sorry @serhiy-storchaka, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 2d2f85517f8216146a2f888d1ad4d765b3be2339 3.8

pablogsal pushed a commit to pablogsal/cpython that referenced this pull request Mar 3, 2020
@serhiy-storchaka @pablogsal
[3.7] bpo-39831: Fix a reference leak in PyErr_WarnEx(). (pythonGH-18750
5e828a6 
).

(cherry picked from commit 2d2f855)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
pablogsal pushed a commit to pablogsal/cpython that referenced this pull request Mar 3, 2020
@serhiy-storchaka @pablogsal
[3.8] bpo-39831: Fix a reference leak in PyErr_WarnEx(). (pythonGH-18750
bd1f923 
)

(cherry picked from commit 2d2f855)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Mar 3, 2020

GH-18761 is a backport of this pull request to the 3.8 branch.

pablogsal added a commit that referenced this pull request Mar 3, 2020
@pablogsal @serhiy-storchaka
[3.8] bpo-39831: Fix a reference leak in PyErr_WarnEx(). (GH-18750) (G…
394dc0d 
…H-18761)

(cherry picked from commit 2d2f855)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
pablogsal added a commit that referenced this pull request Mar 3, 2020
@pablogsal @serhiy-storchaka
[3.7] bpo-39831: Fix a reference leak in PyErr_WarnEx(). (GH-18750). (G…
499c926 
…H-18760)

(cherry picked from commit 2d2f855)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Mar 3, 2020
@serhiy-storchaka
[3.7] bpo-39831: Fix a reference leak in PyErr_WarnEx(). (pythonGH-18750
151fcec 
).

(cherry picked from commit 2d2f855)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull request Mar 8, 2020
@serhiy-storchaka
[3.7] bpo-39831: Fix a reference leak in PyErr_WarnEx(). (GH-18750). (G…
89fabe5 
…H-18765)

(cherry picked from commit 2d2f855)
@serhiy-storchaka serhiy-storchaka removed their assignment Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@serhiy-storchaka @miss-islington @bedevere-bot @pablogsal @the-knights-who-say-ni