Skip to content

[3.8] bpo-38380: Update macOS & Windows builds to SQLite v3.31.1 (GH-18678) #18740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
miss-islington merged 1 commit into from
Mar 2, 2020
Merged

[3.8] bpo-38380: Update macOS & Windows builds to SQLite v3.31.1 (GH-18678) #18740

miss-islington merged 1 commit into from
Mar 2, 2020

Conversation

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Mar 2, 2020 •
edited by bedevere-bot
Loading

Automerge-Triggered-By: @zooba
(cherry picked from commit 1382c32)

Co-authored-by: Erlend Egeberg Aasland erlend.aasland@innova.no

https://bugs.python.org/issue38380

@miss-islington
bpo-38380: Update macOS & Windows builds to SQLite v3.31.1 (pythonGH-…
ec583f7 
…18678)

Automerge-Triggered-By: @zooba
(cherry picked from commit 1382c32)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@miss-islington miss-islington requested review from a team as code owners March 2, 2020 12:25
@bedevere-bot bedevere-bot mentioned this pull request Mar 2, 2020
Merged
@miss-islington
Copy link
Contributor Author

miss-islington commented Mar 2, 2020

@erlend-aasland: Status check is done, and it's a success ✅ .

3 similar comments
@miss-islington
Copy link
Contributor Author

miss-islington commented Mar 2, 2020

@erlend-aasland: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

miss-islington commented Mar 2, 2020

@erlend-aasland: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

miss-islington commented Mar 2, 2020

@erlend-aasland: Status check is done, and it's a success ✅ .

@codecov
Copy link

codecov bot commented Mar 2, 2020 •
edited
Loading

Codecov Report

Merging #18740 into 3.8 will decrease coverage by 2.66%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##              3.8   #18740       +/-   ##
===========================================
- Coverage   82.09%   79.42%    -2.67%     
===========================================
  Files        1919      385     -1534     
  Lines      582302   174746   -407556     
  Branches    43739        0    -43739     
===========================================
- Hits       478016   138793   -339223     
+ Misses      94712    35953    -58759     
+ Partials     9574        0     -9574
Impacted Files Coverage Δ
Modules/_sha3/clinic/sha3module.c.h 95.34% <0.00%> (-4.66%) ⬇️
Include/cpython/abstract.h 96.87% <0.00%> (-3.13%) ⬇️
Modules/clinic/mathmodule.c.h 86.56% <0.00%> (-2.24%) ⬇️
Objects/codeobject.c 82.72% <0.00%> (-2.06%) ⬇️
Objects/classobject.c 60.94% <0.00%> (-1.95%) ⬇️
Modules/clinic/md5module.c.h 93.33% <0.00%> (-1.67%) ⬇️
Modules/clinic/sha1module.c.h 93.33% <0.00%> (-1.67%) ⬇️
Modules/_sqlite/util.c 60.86% <0.00%> (-1.64%) ⬇️
Modules/clinic/sha256module.c.h 92.59% <0.00%> (-1.53%) ⬇️
Modules/clinic/sha512module.c.h 92.59% <0.00%> (-1.53%) ⬇️
... and 1700 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f28b0c7...ec583f7. Read the comment docs.

@miss-islington
Copy link
Contributor Author

miss-islington commented Mar 2, 2020

@erlend-aasland: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 7ad9982 into python:3.8 Mar 2, 2020
@miss-islington miss-islington deleted the backport-1382c32-3.8 branch March 2, 2020 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zooba zooba zooba approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@miss-islington @zooba @the-knights-who-say-ni @bedevere-bot