Skip to content

[3.8] bpo-38913: Fix segfault in Py_BuildValue("(sGH-O)", ...) if entered with exception raised. (GH-18656). #18732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
serhiy-storchaka merged 1 commit into from
Mar 2, 2020
Merged

[3.8] bpo-38913: Fix segfault in Py_BuildValue("(sGH-O)", ...) if entered with exception raised. (GH-18656). #18732

serhiy-storchaka merged 1 commit into from
Mar 2, 2020

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Mar 2, 2020 •
edited by bedevere-bot
Loading

(cherry picked from commit 28d0bca)

https://bugs.python.org/issue38913

@serhiy-storchaka
[3.8] bpo-38913: Fix segfault in Py_BuildValue("(sGH-O)", ...) if ent…
b8b0bb1 
…ered with exception raised. (pythonGH-18656).

(cherry picked from commit 28d0bca)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot bedevere-bot mentioned this pull request Mar 2, 2020
Merged
@bedevere-bot bedevere-bot added type-bug An unexpected behavior, bug, or error awaiting core review labels Mar 2, 2020
@codecov
Copy link

codecov bot commented Mar 2, 2020

Codecov Report

Merging #18732 into 3.8 will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              3.8   #18732      +/-   ##
==========================================
+ Coverage   82.09%   82.11%   +0.02%     
==========================================
  Files        1919     1918       -1     
  Lines      582263   576927    -5336     
  Branches    43739    43739              
==========================================
- Hits       477981   473724    -4257     
+ Misses      94712    93632    -1080     
- Partials     9570     9571       +1
Impacted Files Coverage Δ
Lib/distutils/tests/test_bdist_rpm.py 30.00% <0.00%> (-65.00%) ⬇️
Lib/distutils/command/bdist_rpm.py 7.63% <0.00%> (-56.88%) ⬇️
Modules/_decimal/libmpdec/umodarith.h 80.76% <0.00%> (-19.24%) ⬇️
Lib/test/test_urllib2net.py 76.68% <0.00%> (-13.99%) ⬇️
Lib/test/test_smtpnet.py 78.57% <0.00%> (-7.15%) ⬇️
Lib/ftplib.py 63.72% <0.00%> (-6.08%) ⬇️
Lib/test/test_ftplib.py 87.08% <0.00%> (-4.74%) ⬇️
Tools/scripts/db2pickle.py 17.82% <0.00%> (-3.97%) ⬇️
Lib/test/test_socket.py 72.14% <0.00%> (-3.89%) ⬇️
Tools/scripts/pickle2db.py 16.98% <0.00%> (-3.78%) ⬇️
... and 332 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12b7143...b8b0bb1. Read the comment docs.

@serhiy-storchaka serhiy-storchaka merged commit a7b8a96 into python:3.8 Mar 2, 2020
@serhiy-storchaka serhiy-storchaka deleted the backport-28d0bca-3.8 branch February 19, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@serhiy-storchaka @the-knights-who-say-ni @bedevere-bot