Skip to content

[3.8] bpo-39815: add cached_property to all (GH-18726) #18728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pablogsal merged 1 commit into from
Mar 2, 2020
Merged

[3.8] bpo-39815: add cached_property to all (GH-18726) #18728

pablogsal merged 1 commit into from
Mar 2, 2020

Conversation

@pablogsal
Copy link
Member

@pablogsal pablogsal commented Mar 1, 2020 •
edited by bedevere-bot
Loading

Automerge-Triggered-By: @pablogsal.
(cherry picked from commit 217dce9)

Co-authored-by: Hakan Çelik hakancelik96@outlook.com

https://bugs.python.org/issue39815

@pablogsal pablogsal requested a review from rhettinger as a code owner March 1, 2020 23:40
@bedevere-bot bedevere-bot mentioned this pull request Mar 1, 2020
Merged
@hakancelikdev @pablogsal
[3.8] bpo-39815: add cached_property to all (pythonGH-18726)
dac5a02 
Automerge-Triggered-By: @pablogsal.
(cherry picked from commit 217dce9)

Co-authored-by: Hakan Çelik <hakancelik96@outlook.com>
@pablogsal pablogsal force-pushed the backport-217dce9-3.8 branch from d999979 to dac5a02 Compare March 1, 2020 23:41
@codecov
Copy link

codecov bot commented Mar 2, 2020 •
edited
Loading

Codecov Report

Merging #18728 into 3.8 will increase coverage by 1.19%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##              3.8   #18728       +/-   ##
===========================================
+ Coverage   82.09%   83.28%    +1.19%     
===========================================
  Files        1919     1538      -381     
  Lines      582263   409674   -172589     
  Branches    43739    43739               
===========================================
- Hits       477993   341206   -136787     
+ Misses      94701    58900    -35801     
+ Partials     9569     9568        -1
Impacted Files Coverage Δ
Lib/distutils/tests/test_bdist_rpm.py 30.00% <0.00%> (-65.00%) ⬇️
Lib/distutils/command/bdist_rpm.py 7.63% <0.00%> (-56.88%) ⬇️
Lib/test/test_urllib2net.py 76.68% <0.00%> (-13.99%) ⬇️
Lib/test/test_smtpnet.py 78.57% <0.00%> (-7.15%) ⬇️
Lib/ftplib.py 63.72% <0.00%> (-6.08%) ⬇️
Lib/test/test_ftplib.py 87.08% <0.00%> (-4.74%) ⬇️
Tools/scripts/db2pickle.py 17.82% <0.00%> (-3.97%) ⬇️
Lib/test/test_socket.py 72.14% <0.00%> (-3.89%) ⬇️
Tools/scripts/pickle2db.py 16.98% <0.00%> (-3.78%) ⬇️
Lib/test/test_asyncio/test_base_events.py 91.82% <0.00%> (-3.30%) ⬇️
... and 430 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce720d3...dac5a02. Read the comment docs.

@pablogsal pablogsal merged commit 12b7143 into python:3.8 Mar 2, 2020
@pablogsal pablogsal deleted the backport-217dce9-3.8 branch March 2, 2020 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pablogsal @the-knights-who-say-ni @bedevere-bot @hakancelikdev