[3.8] bpo-39548: Fix handling of 'WWW-Authenticate' header for Digest Auth (GH-18338) #18712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ythonGH-18338) * bpo-39548: Fix handling of 'WWW-Authenticate' header for Digest authentication - The 'qop' value in the 'WWW-Authenticate' header is optional. The presence of 'qop' in the header should be checked before its value is parsed with 'split'. Signed-off-by: Stephen Balousek <stephen@balousek.net> * bpo-39548: Fix handling of 'WWW-Authenticate' header for Digest authentication - Add NEWS item Signed-off-by: Stephen Balousek <stephen@balousek.net> * Update Misc/NEWS.d/next/Library/2020-02-06-05-33-52.bpo-39548.DF4FFe.rst Co-Authored-By: Brandt Bucher <brandtbucher@gmail.com> Co-authored-by: Brandt Bucher <brandtbucher@gmail.com> (cherry picked from commit 5e260e0) Co-authored-by: Stephen Balousek <sbalousek@users.noreply.github.com>
orsenthil
approved these changes
Feb 29, 2020
Codecov Report
@@ Coverage Diff @@
## 3.8 #18712 +/- ##
===========================================
+ Coverage 82.08% 83.28% +1.19%
===========================================
Files 1919 1571 -348
Lines 582229 415244 -166985
Branches 43736 44484 +748
===========================================
- Hits 477944 345825 -132119
+ Misses 94716 59768 -34948
- Partials 9569 9651 +82
Continue to review full report at Codecov.
|
Contributor
Author
|
@sbalousek and @orsenthil: Status check is done, and it's a success ✅ . |
Contributor
Author
|
@sbalousek and @orsenthil: Status check is done, and it's a success ✅ . |
Contributor
Author
|
@sbalousek and @orsenthil: Status check is done, and it's a failure ❌ . |
3 similar comments
Contributor
Author
|
@sbalousek and @orsenthil: Status check is done, and it's a failure ❌ . |
Contributor
Author
|
@sbalousek and @orsenthil: Status check is done, and it's a failure ❌ . |
Contributor
Author
|
@sbalousek and @orsenthil: Status check is done, and it's a failure ❌ . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
presence of 'qop' in the header should be checked before its value
is parsed with 'split'.
Signed-off-by: Stephen Balousek stephen@balousek.net
Signed-off-by: Stephen Balousek stephen@balousek.net
Co-Authored-By: Brandt Bucher brandtbucher@gmail.com
Co-authored-by: Brandt Bucher brandtbucher@gmail.com
(cherry picked from commit 5e260e0)
Co-authored-by: Stephen Balousek sbalousek@users.noreply.github.com
https://bugs.python.org/issue39548