bpo-39781: Do not jump when select in IDLE codecontext #18683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and use lesser weight single quotes.
terryjreedy
added
type-bug
Member
Author
|
I think that this is ready to merge (tomorrow). The main problem I had is that 'sel' is a tag for some purposes, like tag_add, but tag_prevrange('sel', '1.0') returns an empty tuple even when there is a selection. After failing to make it work, I found a solution in EditorWindow.get_selection_indices. Text.selection_get also works (and also raises TclError when no selection). |
terryjreedy
commented
Feb 28, 2020
| """ | ||
| try: | ||
| self.context.index("sel.first") | ||
| except tkinter.TclError: |
Member
Author
There was a problem hiding this comment.
Everything after this is the old code indented.
Contributor
|
Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
|
GH-18688 is a backport of this pull request to the 3.8 branch. |
|
GH-18689 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 28, 2020
Previously, the button-up part of selecting with a mouse was treated as a click that meant 'jump' to this line, which modified the context and undid the selection (cherry picked from commit c705fd1) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
miss-islington
added a commit
that referenced
this pull request
Feb 28, 2020
Previously, the button-up part of selecting with a mouse was treated as a click that meant 'jump' to this line, which modified the context and undid the selection (cherry picked from commit c705fd1) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
miss-islington
added a commit
that referenced
this pull request
Feb 28, 2020
Previously, the button-up part of selecting with a mouse was treated as a click that meant 'jump' to this line, which modified the context and undid the selection (cherry picked from commit c705fd1) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
sthagen
added a commit
to sthagen/python-cpython
that referenced
this pull request
Feb 28, 2020
bpo-39781: Do not jump when select in IDLE codecontext (pythonGH-18683)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the button-up part of selecting with a mouse was treated as a click
that meant 'jump' to this line, which modified the context and undid the selection
https://bugs.python.org/issue39781