Skip to content

bpo-38380: Update macOS & Windows builds to SQLite v3.31.1 #18678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
miss-islington merged 3 commits into from
Mar 2, 2020
Merged

bpo-38380: Update macOS & Windows builds to SQLite v3.31.1 #18678

miss-islington merged 3 commits into from
Mar 2, 2020

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Feb 27, 2020 •
edited by miss-islington
Loading

@erlend-aasland erlend-aasland requested review from a team as code owners February 27, 2020 14:59
@codecov
Copy link

codecov bot commented Feb 27, 2020 •
edited
Loading

Codecov Report

Merging #18678 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #18678     +/-   ##
=========================================
  Coverage   82.12%   82.13%             
=========================================
  Files        1956     1955      -1     
  Lines      589830   584773   -5057     
  Branches    44477    44489     +12     
=========================================
- Hits       484427   480326   -4101     
+ Misses      95752    94800    -952     
+ Partials     9651     9647      -4
Impacted Files Coverage Δ
Lib/distutils/tests/test_bdist_rpm.py 30.00% <0.00%> (-65.00%) ⬇️
Lib/distutils/command/bdist_rpm.py 7.63% <0.00%> (-56.88%) ⬇️
Modules/_decimal/libmpdec/umodarith.h 80.76% <0.00%> (-19.24%) ⬇️
Lib/test/test_urllib2net.py 76.92% <0.00%> (-13.85%) ⬇️
Lib/test/test_smtpnet.py 78.57% <0.00%> (-7.15%) ⬇️
Lib/ftplib.py 63.85% <0.00%> (-6.06%) ⬇️
Lib/test/test_ftplib.py 87.11% <0.00%> (-4.72%) ⬇️
Tools/scripts/db2pickle.py 17.82% <0.00%> (-3.97%) ⬇️
Tools/scripts/pickle2db.py 16.98% <0.00%> (-3.78%) ⬇️
Lib/test/test_socket.py 71.94% <0.00%> (-3.77%) ⬇️
... and 350 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02a4d57...6a89f64. Read the comment docs.

@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Feb 27, 2020

FYI: The Windows build fails because I forgot to git tag the upgrade with sqlite-3.30.1.0 in python/cpython-source-deps#17. I've notified the maintainers, hoping that one of them can tag it for me, since I lack the permissions to do so (and creating a PR for just one tag is not possible, AFAIK.)

@erlend-aasland erlend-aasland changed the title bpo-38380: Update macOS & Windows builds to SQLite v3.30.1 bpo-38380: Update macOS & Windows builds to SQLite v3.31.1 Feb 29, 2020
@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Feb 29, 2020

FYI, updated to most recent SQLite3 version. See bug tracker for discussion.

zooba
zooba reviewed Mar 2, 2020
View reviewed changes
@miss-islington
Copy link
Contributor

miss-islington commented Mar 2, 2020

@erlend-aasland: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor

miss-islington commented Mar 2, 2020

Sorry, I can't merge this PR. Reason: Required status check "Azure Pipelines PR" is expected..

@zooba
Copy link
Member

zooba commented Mar 2, 2020

Closing/reopening to retrigger Azure Pipelines

@zooba zooba closed this Mar 2, 2020
@zooba zooba reopened this Mar 2, 2020
@miss-islington
Copy link
Contributor

miss-islington commented Mar 2, 2020

@erlend-aasland: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington
Copy link
Contributor

miss-islington commented Mar 2, 2020

@erlend-aasland: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor

miss-islington commented Mar 2, 2020

Sorry, I can't merge this PR. Reason: Required status check "Azure Pipelines PR" is expected..

1 similar comment
@miss-islington
Copy link
Contributor

miss-islington commented Mar 2, 2020

Sorry, I can't merge this PR. Reason: Required status check "Azure Pipelines PR" is expected..

@miss-islington
Copy link
Contributor

miss-islington commented Mar 2, 2020

@erlend-aasland: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 1382c32 into python:master Mar 2, 2020
@miss-islington
Copy link
Contributor

miss-islington commented Mar 2, 2020

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 2, 2020
@miss-islington
bpo-38380: Update macOS & Windows builds to SQLite v3.31.1 (pythonGH-…
ec583f7 
…18678)

Automerge-Triggered-By: @zooba
(cherry picked from commit 1382c32)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@bedevere-bot
Copy link

bedevere-bot commented Mar 2, 2020

GH-18740 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 2, 2020
@miss-islington
bpo-38380: Update macOS & Windows builds to SQLite v3.31.1 (pythonGH-…
961ec8b 
…18678)

Automerge-Triggered-By: @zooba
(cherry picked from commit 1382c32)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@bedevere-bot
Copy link

bedevere-bot commented Mar 2, 2020

GH-18741 is a backport of this pull request to the 3.7 branch.

@erlend-aasland erlend-aasland deleted the fix-issue-38380 branch March 2, 2020 12:27
miss-islington added a commit that referenced this pull request Mar 2, 2020
@miss-islington
bpo-38380: Update macOS & Windows builds to SQLite v3.31.1 (GH-18678)
7ad9982 
Automerge-Triggered-By: @zooba
(cherry picked from commit 1382c32)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
miss-islington added a commit that referenced this pull request Mar 2, 2020
@miss-islington
bpo-38380: Update macOS & Windows builds to SQLite v3.31.1 (GH-18678)
7ca251b 
Automerge-Triggered-By: @zooba
(cherry picked from commit 1382c32)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zooba zooba zooba approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@erlend-aasland @miss-islington @zooba @bedevere-bot @the-knights-who-say-ni