Skip to content

bpo-39770: Remove unnecessary descriptor counting#18675

Merged
vstinner merged 1 commit into
python:masterfrom
petdance:bpo-39770-D
Mar 4, 2020
Merged

bpo-39770: Remove unnecessary descriptor counting#18675
vstinner merged 1 commit into
python:masterfrom
petdance:bpo-39770-D

Conversation

@petdance

@petdance petdance commented Feb 27, 2020

Copy link
Copy Markdown
Contributor

The array_modexec function in Modules/arraymodule.c has a loop that calculates the number of elements in the descriptors array. This size was used at one point, but is no longer. The loop can be removed.

https://bugs.python.org/issue39770

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@petdance

Thank you for the contribution.
This is nice catch :)

@vstinner

vstinner commented Mar 4, 2020

Copy link
Copy Markdown
Member

Likely a ghost from the past.

@petdance
petdance deleted the bpo-39770-D branch March 5, 2020 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants