Skip to content

bpo-38913: Fix segfault in Py_BuildValue("(s#O)", ...) if entered with exception raised. #18656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
serhiy-storchaka merged 2 commits into from
Mar 2, 2020
Merged

bpo-38913: Fix segfault in Py_BuildValue("(s#O)", ...) if entered with exception raised. #18656

serhiy-storchaka merged 2 commits into from
Mar 2, 2020

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Feb 25, 2020 •
edited by bedevere-bot
Loading

@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error needs backport to 3.8 labels Feb 25, 2020
zooba
zooba approved these changes Feb 25, 2020
View reviewed changes
@codecov
Copy link

codecov bot commented Feb 25, 2020

Codecov Report

Merging #18656 into master will increase coverage by 1.13%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #18656       +/-   ##
===========================================
+ Coverage   82.06%   83.20%    +1.13%     
===========================================
  Files        1956     1571      -385     
  Lines      589514   414882   -174632     
  Branches    44464    44464               
===========================================
- Hits       483809   345211   -138598     
+ Misses      96052    60028    -36024     
+ Partials     9653     9643       -10
Impacted Files Coverage Δ
Lib/distutils/tests/test_bdist_rpm.py 30.00% <0.00%> (-65.00%) ⬇️
Lib/distutils/command/bdist_rpm.py 7.63% <0.00%> (-56.88%) ⬇️
Lib/test/test_urllib2net.py 76.92% <0.00%> (-13.85%) ⬇️
Lib/test/test_smtpnet.py 78.57% <0.00%> (-7.15%) ⬇️
Lib/ftplib.py 63.85% <0.00%> (-6.06%) ⬇️
Lib/test/test_ftplib.py 87.11% <0.00%> (-4.72%) ⬇️
Tools/scripts/db2pickle.py 17.82% <0.00%> (-3.97%) ⬇️
Tools/scripts/pickle2db.py 16.98% <0.00%> (-3.78%) ⬇️
Lib/test/test_socket.py 71.94% <0.00%> (-3.77%) ⬇️
Lib/test/test_asyncio/test_base_events.py 91.84% <0.00%> (-3.30%) ⬇️
... and 432 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb8ac57...ee04d2f. Read the comment docs.

@serhiy-storchaka serhiy-storchaka merged commit 28d0bca into python:master Mar 2, 2020
@miss-islington
Copy link
Contributor

miss-islington commented Mar 2, 2020

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Mar 2, 2020

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 28d0bcac8b7e6dbd28311f1283dabb6a4d649fcb 3.8

@serhiy-storchaka serhiy-storchaka deleted the buildvalue-error branch March 2, 2020 06:43
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Mar 2, 2020
@serhiy-storchaka
[3.8] bpo-38913: Fix segfault in Py_BuildValue("(sGH-O)", ...) if ent…
b8b0bb1 
…ered with exception raised. (pythonGH-18656).

(cherry picked from commit 28d0bca)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Mar 2, 2020

GH-18732 is a backport of this pull request to the 3.8 branch.

serhiy-storchaka added a commit that referenced this pull request Mar 2, 2020
@serhiy-storchaka
[3.8] bpo-38913: Fix segfault in Py_BuildValue("(sGH-O)", ...) if ent…
a7b8a96 
…ered with exception raised. (GH-18656). (GH-18732)

(cherry picked from commit 28d0bca)
@serhiy-storchaka serhiy-storchaka removed their assignment Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@methane methane methane approved these changes

@zooba zooba zooba approved these changes

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@serhiy-storchaka @miss-islington @bedevere-bot @methane @zooba @the-knights-who-say-ni