Skip to content

bpo-39718: add TYPE_IGNORE, COLONEQUAL to py38 changes in token #18598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
terryjreedy merged 2 commits into from
Feb 28, 2020
Merged

bpo-39718: add TYPE_IGNORE, COLONEQUAL to py38 changes in token #18598

terryjreedy merged 2 commits into from
Feb 28, 2020

Conversation

@hauntsaninja
Copy link
Contributor

@hauntsaninja hauntsaninja commented Feb 21, 2020 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Feb 21, 2020
terryjreedy
terryjreedy approved these changes Feb 28, 2020
View reviewed changes
Copy link
Member

@terryjreedy terryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified additions in token.py. Thank you for the clean ready-to-merge patch.

@terryjreedy terryjreedy merged commit c2f7eb2 into python:master Feb 28, 2020
@miss-islington
Copy link
Contributor

miss-islington commented Feb 28, 2020

Thanks @hauntsaninja for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Feb 28, 2020

GH-18696 is a backport of this pull request to the 3.8 branch.

@hauntsaninja hauntsaninja deleted the tokendoc branch February 28, 2020 23:25
miss-islington added a commit that referenced this pull request Feb 28, 2020
@miss-islington @hauntsaninja
bpo-39718: add TYPE_IGNORE, COLONEQUAL to py38 changes in token (GH-1…
7f53d87 
…8598)

(cherry picked from commit c2f7eb2)

Co-authored-by: Shantanu <hauntsaninja@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy terryjreedy approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hauntsaninja @miss-islington @bedevere-bot @terryjreedy @the-knights-who-say-ni