Skip to content

fix(doc): set correct RST syntax for c:function - #18589

Merged
vstinner merged 1 commit into
python:masterfrom
jd:fix-typo-doc-tracemalloc-memory-c-api
Feb 21, 2020
Merged

vstinner merged 1 commit into
python:masterfrom
jd:fix-typo-doc-tracemalloc-memory-c-api

Conversation

@jd

@jd jd commented Feb 21, 2020

Copy link
Copy Markdown
Contributor

The current content is not rendered since the syntax is not correct.

The current content is not rendered since the syntax is not correct.

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vstinner

Copy link
Copy Markdown
Member

@JulienPalard the "make suspicious" didnt notice this one.

@vstinner
vstinner merged commit d4d17fd into python:master Feb 21, 2020
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @jd for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington

Copy link
Copy Markdown
Contributor

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @jd for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot

Copy link
Copy Markdown

GH-18591 is a backport of this pull request to the 3.8 branch.

@vstinner

Copy link
Copy Markdown
Member

@jd is a backport to 3.7 needed? I didnt check when the do was added.

miss-islington added a commit that referenced this pull request Feb 21, 2020
The current content is not rendered since the syntax is not correct.
(cherry picked from commit d4d17fd)

Co-authored-by: Julien Danjou <julien@danjou.info>
@jd

jd commented Feb 21, 2020

Copy link
Copy Markdown
Contributor Author

@vstinner yes that needs to be backported to 3.7 too

@JulienPalard

Copy link
Copy Markdown
Member

@vstinner IIRC the make suspicious mostly spots errors from the initial Latex import, it's more the role of sphinx to spot those ones. I also have an issue opened sphinx side about sphinx not spotting some "obvious" errors that are sometimes spotted sometimes not.

@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @jd for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot

Copy link
Copy Markdown

GH-18593 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 21, 2020
The current content is not rendered since the syntax is not correct.
(cherry picked from commit d4d17fd)

Co-authored-by: Julien Danjou <julien@danjou.info>
miss-islington added a commit that referenced this pull request Feb 21, 2020
The current content is not rendered since the syntax is not correct.
(cherry picked from commit d4d17fd)

Co-authored-by: Julien Danjou <julien@danjou.info>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants