Skip to content

bpo-32892: Update the documentation for handling constants in AST. #18514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
serhiy-storchaka merged 2 commits into from
Feb 17, 2020
Merged

bpo-32892: Update the documentation for handling constants in AST. #18514

serhiy-storchaka merged 2 commits into from
Feb 17, 2020

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Feb 15, 2020 •
edited by bedevere-bot
Loading

I included these changes in the PR for other AST changes #9605, but it was not merged in 3.8.

https://bugs.python.org/issue32892

isidentical
isidentical reviewed Feb 15, 2020
View reviewed changes
Copy link
Member

@isidentical isidentical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These might clarify the doc a bit

@serhiy-storchaka @isidentical
Apply suggestions from code review
c01e0d3 
Co-Authored-By: Batuhan Taşkaya <47358913+isidentical@users.noreply.github.com>
@serhiy-storchaka
Copy link
Member Author

serhiy-storchaka commented Feb 16, 2020

Thank you for your corrections @isidentical! I always had problems with articles which are absent in my native language.

@serhiy-storchaka serhiy-storchaka merged commit 85a2eef into python:master Feb 17, 2020
@miss-islington
Copy link
Contributor

miss-islington commented Feb 17, 2020

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the ast-constant-docs branch February 17, 2020 09:03
@bedevere-bot
Copy link

bedevere-bot commented Feb 17, 2020

GH-18534 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Feb 17, 2020
@miss-islington @serhiy-storchaka
bpo-32892: Update the documentation for handling constants in AST. (G…
988aeba 
…H-18514)

(cherry picked from commit 85a2eef)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@isidentical isidentical isidentical approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@serhiy-storchaka @miss-islington @bedevere-bot @isidentical @the-knights-who-say-ni