Repository navigation
Conversation
Codecov Report
@@ Coverage Diff @@
## master #18427 +/- ##
=========================================
Coverage 82.11% 82.12%
=========================================
Files 1955 1954 -1
Lines 588948 583956 -4992
Branches 44428 44447 +19
=========================================
- Hits 483629 479561 -4068
+ Misses 95669 94749 -920
+ Partials 9650 9646 -4
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I accidentally polluted the previous PR (#17729) with recent commits to unrelated files, but I think this might still be a viable speed boost--the code should be the same.
This is essentially a lazy non-recursive recursive-merge-sort, which turns out to be exactly equivalent to repeated heapreplace calls, with one exception: it eliminates the siftdown at the end of each siftup call, which is unnecessary because the inputs are already sorted. This modestly improves performance in almost all cases, and especially improves performance when one iterator keeps "winning."
https://bugs.python.org/issue38938