Skip to content

bpo-38149: Call sys.audit() only once per call for glob.glob().#18360

Merged
serhiy-storchaka merged 1 commit into
python:masterfrom
serhiy-storchaka:audit-glob
Feb 6, 2020
Merged

bpo-38149: Call sys.audit() only once per call for glob.glob().#18360
serhiy-storchaka merged 1 commit into
python:masterfrom
serhiy-storchaka:audit-glob

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Feb 5, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error needs backport to 3.8 labels Feb 5, 2020
@codecov

codecov Bot commented Feb 5, 2020

Copy link
Copy Markdown

Codecov Report

Merging #18360 into master will increase coverage by 1.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #18360       +/-   ##
===========================================
+ Coverage   82.11%   83.19%    +1.07%     
===========================================
  Files        1955     1570      -385     
  Lines      588856   414363   -174493     
  Branches    44427    44427               
===========================================
- Hits       483557   344729   -138828     
+ Misses      95647    59988    -35659     
+ Partials     9652     9646        -6
Impacted Files Coverage Δ
Lib/distutils/tests/test_bdist_rpm.py 30.00% <0.00%> (-65.00%) ⬇️
Lib/distutils/command/bdist_rpm.py 7.63% <0.00%> (-56.88%) ⬇️
Lib/test/test_urllib2net.py 76.92% <0.00%> (-13.85%) ⬇️
Lib/test/test_smtpnet.py 78.57% <0.00%> (-7.15%) ⬇️
Lib/ftplib.py 63.85% <0.00%> (-6.06%) ⬇️
Lib/test/test_ftplib.py 87.11% <0.00%> (-4.72%) ⬇️
Tools/scripts/db2pickle.py 17.82% <0.00%> (-3.97%) ⬇️
Tools/scripts/pickle2db.py 16.98% <0.00%> (-3.78%) ⬇️
Lib/test/test_socket.py 71.94% <0.00%> (-3.77%) ⬇️
Lib/test/test_asyncio/test_base_events.py 91.84% <0.00%> (-3.30%) ⬇️
... and 437 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 787b6d5...0f468c4. Read the comment docs.

@serhiy-storchaka
serhiy-storchaka merged commit 54b4f14 into python:master Feb 6, 2020
@miss-islington

miss-islington commented Feb 6, 2020

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@serhiy-storchaka
serhiy-storchaka deleted the audit-glob branch February 6, 2020 08:26
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 6, 2020
@serhiy-storchaka @miss-islington
bpo-38149: Call sys.audit() only once per call for glob.glob(). (pyth…
79b1949 
…onGH-18360)

(cherry picked from commit 54b4f14)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot

bedevere-bot commented Feb 6, 2020

Copy link
Copy Markdown

GH-18373 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Feb 6, 2020
@miss-islington @serhiy-storchaka
bpo-38149: Call sys.audit() only once per call for glob.glob(). (GH-1…
708f472 
…8360)

(cherry picked from commit 54b4f14)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zooba zooba zooba approved these changes
@corona10 corona10 corona10 approved these changes

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@serhiy-storchaka @miss-islington @bedevere-bot @zooba @corona10 @the-knights-who-say-ni