gh-75008: guess lineterminator in csv.Sniffer#18336
Open
vmax wants to merge 5 commits into
Open
Conversation
rruuaanng
reviewed
Oct 9, 2024
rruuaanng
reviewed
Oct 10, 2024
rruuaanng
left a comment
rruuaanng
left a comment
Contributor
There was a problem hiding this comment.
Maybe csv.py should be sent to another reviewer for review.
|
This PR is stale because it has been open for 30 days with no activity. |
Member
|
Thank you for the patch, and sorry that it was left without attention for so long. The sniffer was rewritten on the main branch (gh-83273) and this patch no longer applies. It should be easier now: the sample is split into lines keeping their line breaks, so detection can count |
serhiy-storchaka
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue30825