Repository navigation
gh-72463: Fix Lib/ctypes/test_loading.py so that test_find reports skipped - #18312
Conversation
…rather than passed when no libraries to test are found.
|
I know this is not "urgent" - but it always struck me as strange that a function that always returns NULL - when something, at least once, is expected - should pass - when perhaps the function has failed every time . |
Lib/ctypes/test_loading.py so that test_find reports skippedLib/ctypes/test_loading.py so that test_find reports skipped
serhiy-storchaka
left a comment
There was a problem hiding this comment.
LGTM. I fixed an error and removed a NEWS entry which is not required for such kind of changes.
|
Thanks @aixtools for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
…skipped (pythonGH-18312) (cherry picked from commit 04d1000) Co-authored-by: Michael Felt <aixtools@users.noreply.github.com>
|
GH-116136 is a backport of this pull request to the 3.12 branch. |
…skipped (pythonGH-18312) (cherry picked from commit 04d1000) Co-authored-by: Michael Felt <aixtools@users.noreply.github.com>
|
GH-116137 is a backport of this pull request to the 3.11 branch. |
|
Fix
Lib/ctypes/test_loading.pyso thattest_findreports skipped rather than passed when no libraries to test are found.Backport to 3.7 and 3.8 is requested.
https://bugs.python.org/issue28276