bpo-39492: Fix a reference cycle between reducer_override and a Pickler instance#18266
Conversation
|
@pitrou if you want to take a look. |
pitrou
left a comment
pitrou
left a comment
There was a problem hiding this comment.
Thank you for noticing and for the fix.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
…/cpython into fix-pickler-reference-cycle
|
@pierreglaser: Status check is done, and it's a success ✅ . |
|
Thanks @pierreglaser for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
|
Thanks @pierreglaser for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
|
I'm having trouble backporting to |
|
Thanks @pierreglaser for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
|
GH-18316 is a backport of this pull request to the 3.8 branch. |
… Pickler instance (GH-18266) (#18316) https://bugs.python.org/issue39492 Automerge-Triggered-By: @pitrou (cherry picked from commit 0f2f35e) Co-authored-by: Pierre Glaser <pierreglaser@msn.com>
|
Sorry, @pierreglaser, I could not cleanly backport this to |
|
Sorry @pierreglaser, I had trouble checking out the |
|
I'm confused by the bot: was this PR well backported to 3.8? cc @pitrou |
|
It was, but I had to do it manually because the bot failed for some reason. |
5 participants
This also needs a backport to 3.8
https://bugs.python.org/issue39492
Automerge-Triggered-By: @pitrou