Skip to content

bpo-30463 ABC has empty __slots__, with unittest #1822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 5 commits into from
Jun 6, 2017
Merged

bpo-30463 ABC has empty __slots__, with unittest #1822

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e42bb42
ABC has empty __slots__, with unittest
aaronchall May 26, 2017
1df6e54
add Misc/NEWS entry for abc.ABC slots
aaronchall Jun 6, 2017
56fa5b7
Merge branch 'master' into abc_slots
aaronchall Jun 6, 2017
be559a3
remove trailing whitespace
aaronchall Jun 6, 2017
4fad631
Update NEWS
serhiy-storchaka Jun 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lib/abc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ class ABC(metaclass=ABCMeta):
"""Helper class that provides a standard way to create an ABC using
inheritance.
"""
pass
__slots__ = ()


def get_cache_token():
Expand Down
3 changes: 3 additions & 0 deletions Lib/test/test_abc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,6 +402,9 @@ class C(A, B):
C()
self.assertEqual(B.counter, 1)

def test_ABC_has___slots__(self):
self.assertTrue(hasattr(abc.ABC, '__slots__'))


class TestABCWithInitSubclass(unittest.TestCase):
def test_works_with_init_subclass(self):
Expand Down
3 changes: 3 additions & 0 deletions Misc/NEWS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,6 +345,9 @@ Extension Modules
Library
-------

- bpo-30463: Addded empty __slots__ to abc.ABC. This allows subclassers
to deny __dict__ and __weakref__ creation. Patch by Aaron Hall.

- bpo-30520: Loggers are now pickleable.

- bpo-30557: faulthandler now correctly filters and displays exception codes
Expand Down