[3.6] bpo-39453: Multiple backport patch for use after free with list and dict#18206
Closed
corona10 wants to merge 4 commits into
Closed
[3.6] bpo-39453: Multiple backport patch for use after free with list and dict#18206corona10 wants to merge 4 commits into
corona10 wants to merge 4 commits into
Conversation
Hold strong references to list elements while calling PyObject_RichCompareBool().
pythonGH-17765) * [3.7] bpo-38588: Fix possible crashes in dict and list when calling PyObject_RichCompareBool (pythonGH-17734) Take strong references before calling PyObject_RichCompareBool to protect against the case where the object dies during the call.. (cherry picked from commit 2d5bf56) Co-authored-by: Dong-hee Na <donghee.na92@gmail.com> * methane's suggestion methane's suggestion Co-Authored-By: Inada Naoki <songofacandy@gmail.com> Co-authored-by: Inada Naoki <songofacandy@gmail.com>
Member
Author
|
@pablogsal Please take a look in care, this backport patch is including the missing backport patch for 3.6 |
corona10
changed the title
Member
|
Please, create two different PRs then. If we need to revert one of them we don't want to revert everything. |
Member
Author
|
@pablogsal Got it, I close this PR :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue39453