Skip to content

bpo-39430: Fix race condition in lazy imports in tarfile.#18161

Merged
ethanfurman merged 1 commit into
python:masterfrom
serhiy-storchaka:tarfile-import-race-condition
Jan 24, 2020
Merged

bpo-39430: Fix race condition in lazy imports in tarfile.#18161
ethanfurman merged 1 commit into
python:masterfrom
serhiy-storchaka:tarfile-import-race-condition

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Jan 24, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error needs backport to 3.7 labels Jan 24, 2020
@serhiy-storchaka
serhiy-storchaka force-pushed the tarfile-import-race-condition branch from a6d9268 to a38da42 Compare January 24, 2020 09:10
@ethanfurman
ethanfurman merged commit 9017e0b into python:master Jan 24, 2020
@miss-islington

miss-islington commented Jan 24, 2020

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR, and @ethanfurman for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 24, 2020
@serhiy-storchaka @miss-islington
bpo-39430: Fix race condition in lazy imports in tarfile. (pythonGH-1…
29a6661 
…8161)

Use `from ... import ...` to ensure module is fully loaded before accessing its attributes.
(cherry picked from commit 9017e0b)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot

bedevere-bot commented Jan 24, 2020

Copy link
Copy Markdown

GH-18171 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 24, 2020
@serhiy-storchaka @miss-islington
bpo-39430: Fix race condition in lazy imports in tarfile. (pythonGH-1…
d240383 
…8161)

Use `from ... import ...` to ensure module is fully loaded before accessing its attributes.
(cherry picked from commit 9017e0b)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot

bedevere-bot commented Jan 24, 2020

Copy link
Copy Markdown

GH-18172 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Jan 24, 2020
@miss-islington @serhiy-storchaka
bpo-39430: Fix race condition in lazy imports in tarfile. (GH-18161)
ea4a61f 
Use `from ... import ...` to ensure module is fully loaded before accessing its attributes.
(cherry picked from commit 9017e0b)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington added a commit that referenced this pull request Jan 24, 2020
@miss-islington @serhiy-storchaka
bpo-39430: Fix race condition in lazy imports in tarfile. (GH-18161)
1a27435 
Use `from ... import ...` to ensure module is fully loaded before accessing its attributes.
(cherry picked from commit 9017e0b)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@serhiy-storchaka @shihai1991
bpo-39430: Fix race condition in lazy imports in tarfile. (pythonGH-1…
6c494af 
…8161)

Use `from ... import ...` to ensure module is fully loaded before accessing its attributes.
@MaciejGol MaciejGol mannequin mentioned this pull request Apr 10, 2022
Closed
@serhiy-storchaka
serhiy-storchaka deleted the tarfile-import-race-condition branch July 1, 2026 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon brettcannon approved these changes
@ethanfurman ethanfurman ethanfurman approved these changes

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@serhiy-storchaka @miss-islington @bedevere-bot @brettcannon @ethanfurman @the-knights-who-say-ni