Skip to content

improve the documentation of the LOAD_METHOD and CALL_METHOD bytecodes - #18079

Merged
methane merged 1 commit into
python:masterfrom
cfbolz:load-call-method-doc-improvement
Jan 21, 2020
Merged

methane merged 1 commit into
python:masterfrom
cfbolz:load-call-method-doc-improvement

Conversation

@cfbolz

@cfbolz cfbolz commented Jan 20, 2020

Copy link
Copy Markdown
Contributor

I was confused by the documentation of the LOAD_METHOD and CALL_METHOD bytecodes, so I tried to improve it. @methane, would you maybe have the time to take a look?

@aeros

aeros commented Jan 20, 2020

Copy link
Copy Markdown
Contributor

Hmm, I think this is a small enough documentation enhancement that it doesn't require it's own issue and news entry, but feel free to remove it if needed.

@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @cfbolz for the PR, and @methane for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @cfbolz for the PR, and @methane for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington

Copy link
Copy Markdown
Contributor

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 21, 2020
…H-18079)

(cherry picked from commit 8698b34)

Co-authored-by: Carl Friedrich Bolz-Tereick <cfbolz@gmx.de>
@bedevere-bot

Copy link
Copy Markdown

GH-18091 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Jan 21, 2020
(cherry picked from commit 8698b34)

Co-authored-by: Carl Friedrich Bolz-Tereick <cfbolz@gmx.de>
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @cfbolz for the PR, and @methane for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 21, 2020
…H-18079)

(cherry picked from commit 8698b34)

Co-authored-by: Carl Friedrich Bolz-Tereick <cfbolz@gmx.de>
@bedevere-bot

Copy link
Copy Markdown

GH-18092 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Jan 21, 2020
(cherry picked from commit 8698b34)

Co-authored-by: Carl Friedrich Bolz-Tereick <cfbolz@gmx.de>
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants