bpo-39388: IDLE: Fix bug when cancelling out of configdialog#18068
Merged
Conversation
csabella
changed the title
terryjreedy
reviewed
Jan 25, 2020
terryjreedy
left a comment
terryjreedy
left a comment
Member
There was a problem hiding this comment.
A 2nd button bug not caught by missing tests. We wrote changes.clear to be called at this spot. (It is not called anywhere else.) I will add a test that changes is cleared and add news items.
terryjreedy
approved these changes
Jan 25, 2020
terryjreedy
added
needs backport to 3.7
type-bug
Contributor
|
Thanks @csabella for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 25, 2020
|
GH-18178 is a backport of this pull request to the 3.8 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 25, 2020
|
GH-18179 is a backport of this pull request to the 3.7 branch. |
sthagen
added a commit
to sthagen/python-cpython
that referenced
this pull request
Jan 25, 2020
bpo-39388: IDLE: Fix bug when cancelling out of configdialog (pythonGH-18068)
miss-islington
added a commit
that referenced
this pull request
Jan 25, 2020
miss-islington
added a commit
that referenced
this pull request
Jan 25, 2020
Contributor
Author
|
I had some additional test for configdialog in GH-3592 and I rebased it last week. It's not all the missing tests. |
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Jan 31, 2020
…H-18068) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to keybindings were being remembered even when cancelling out of the Config Dialog.
https://bugs.python.org/issue39388