Skip to content

bpo-39384 Fix email.generator.BytesGenerator to flatten non-ascii body.#18056

Closed
msapiro wants to merge 2 commits into
python:masterfrom
msapiro:39384
Closed

bpo-39384 Fix email.generator.BytesGenerator to flatten non-ascii body.#18056
msapiro wants to merge 2 commits into
python:masterfrom
msapiro:39384

Conversation

@msapiro

@msapiro msapiro commented Jan 19, 2020

Copy link
Copy Markdown
Contributor

Add test for same.

email.generator.BytesGenerator throws uncaught UnicodeEncodeError upon flattening a message with a non-encoded, non-ascii message body. This catches that exception and encodes the body with errors='replace'.

https://bugs.python.org/issue39384

@msapiro
msapiro requested a review from a team as a code owner January 19, 2020 00:52
@the-knights-who-say-ni

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@msapiro

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@msapiro

msapiro commented Feb 6, 2020

Copy link
Copy Markdown
Contributor Author

Closing this as unnecessary. See the discussion in the bug report https://bugs.python.org/issue39384, in particular https://bugs.python.org/msg361469

@msapiro msapiro closed this Feb 6, 2020
@msapiro
msapiro deleted the 39384 branch February 6, 2020 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants