Skip to content

bpo-39378: partial of PickleState struct should be traversed. #18046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
serhiy-storchaka merged 1 commit into from
Mar 2, 2020
Merged

bpo-39378: partial of PickleState struct should be traversed. #18046

serhiy-storchaka merged 1 commit into from
Mar 2, 2020

Conversation

@shihai1991
Copy link
Member

@shihai1991 shihai1991 commented Jan 18, 2020 •
edited by bedevere-bot
Loading

@shihai1991 shihai1991 requested review from ncoghlan and serhiy-storchaka and removed request for ncoghlan January 31, 2020 15:56
@shihai1991
Copy link
Member Author

shihai1991 commented Feb 18, 2020

@serhiy-storchaka Hi, serhiy. Do you have free time to review this small PR?
I found you merge this feature in https://bugs.python.org/file39341/pickle_new_ex_protocol_2.patch.

@zhangyangyu zhangyangyu requested review from vstinner and removed request for avassalotti March 2, 2020 05:10
@serhiy-storchaka serhiy-storchaka merged commit 1f577ce into python:master Mar 2, 2020
@miss-islington
Copy link
Contributor

miss-islington commented Mar 2, 2020

Thanks @shihai1991 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 2, 2020
@shihai1991 @miss-islington
bpo-39378: partial of PickleState struct should be traversed. (python…
2dec1f5 
…GH-18046)

(cherry picked from commit 1f577ce)

Co-authored-by: Hai Shi <shihai1992@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Mar 2, 2020

GH-18730 is a backport of this pull request to the 3.8 branch.

@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Mar 2, 2020

Good catch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 2, 2020
@shihai1991 @miss-islington
bpo-39378: partial of PickleState struct should be traversed. (python…
0278c1d 
…GH-18046)

(cherry picked from commit 1f577ce)

Co-authored-by: Hai Shi <shihai1992@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Mar 2, 2020

GH-18731 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Mar 2, 2020
@miss-islington @shihai1991
bpo-39378: partial of PickleState struct should be traversed. (GH-18046)
d3c2435 
(cherry picked from commit 1f577ce)

Co-authored-by: Hai Shi <shihai1992@gmail.com>
miss-islington added a commit that referenced this pull request Mar 2, 2020
@miss-islington @shihai1991
bpo-39378: partial of PickleState struct should be traversed. (GH-18046)
5f2ade2 
(cherry picked from commit 1f577ce)

Co-authored-by: Hai Shi <shihai1992@gmail.com>
@shihai1991
Copy link
Member Author

shihai1991 commented Mar 2, 2020

Thanks, folks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@zhangyangyu zhangyangyu zhangyangyu approved these changes

@vstinner vstinner Awaiting requested review from vstinner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@shihai1991 @miss-islington @bedevere-bot @serhiy-storchaka @zhangyangyu @the-knights-who-say-ni