Skip to content

bpo-39313: Add an option to RefactoringTool for using exec as a function#17967

Merged
miss-islington merged 4 commits into
python:masterfrom
isidentical:bpo-39313
Jan 12, 2020
Merged

bpo-39313: Add an option to RefactoringTool for using exec as a function#17967
miss-islington merged 4 commits into
python:masterfrom
isidentical:bpo-39313

Conversation

@isidentical

@isidentical isidentical commented Jan 12, 2020 •
edited by pablogsal
Loading

Copy link
Copy Markdown
Member

pablogsal
pablogsal requested changes Jan 12, 2020
View reviewed changes
Comment thread Lib/lib2to3/main.py Outdated
@bedevere-bot

bedevere-bot commented Jan 12, 2020

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@isidentical isidentical changed the title bpo-39313: Add an option to RefactoringTool for using no_print_and_exec_statement bpo-39313: Add an option to RefactoringTool for using exec as a function Jan 12, 2020
@isidentical

isidentical commented Jan 12, 2020

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again

@bedevere-bot

bedevere-bot commented Jan 12, 2020

Copy link
Copy Markdown

Thanks for making the requested changes!

@pablogsal: please review the changes made to this pull request.

pablogsal
pablogsal reviewed Jan 12, 2020
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2020-01-12-18-17-00.bpo-39313.DCTsnm.rst Outdated
pablogsal
pablogsal reviewed Jan 12, 2020
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2020-01-12-18-17-00.bpo-39313.DCTsnm.rst Outdated
pablogsal
pablogsal approved these changes Jan 12, 2020
View reviewed changes

@pablogsal pablogsal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LCTM

pablogsal
pablogsal reviewed Jan 12, 2020
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2020-01-12-18-17-00.bpo-39313.DCTsnm.rst Outdated
@isidentical
isidentical requested a review from pablogsal January 12, 2020 21:55
@pablogsal pablogsal self-assigned this Jan 12, 2020
@miss-islington

miss-islington commented Jan 12, 2020

Copy link
Copy Markdown
Contributor

@isidentical: Status check is done, and it's a success ✅ .

@miss-islington
miss-islington merged commit 61b1415 into python:master Jan 12, 2020
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@isidentical @shihai1991
bpo-39313: Add an option to RefactoringTool for using exec as a funct…
3db71f6 
…ion (pythonGH-17967)

https://bugs.python.org/issue39313


Automerge-Triggered-By: @pablogsal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

Assignees

@pablogsal pablogsal

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@isidentical @bedevere-bot @miss-islington @pablogsal @the-knights-who-say-ni