Skip to content

bpo-38901: Allow setting a venv's prompt to the basename of the current directory. #17946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vsajip merged 3 commits into from
Jan 14, 2020
Merged

bpo-38901: Allow setting a venv's prompt to the basename of the current directory. #17946

vsajip merged 3 commits into from
Jan 14, 2020

Conversation

@vsajip
Copy link
Member

@vsajip vsajip commented Jan 10, 2020 •
edited by bedevere-bot
Loading

When a prompt value of '.' is specified, os.path.basename(os.getcwd()) is used to configure the prompt for the created venv.

https://bugs.python.org/issue38901

vsajip added 2 commits January 10, 2020 22:26
@vsajip
bpo-38901: Allow setting a venv's prompt to the basename of the curre…
f22cdd0 
…nt directory.

When a prompt value of '.' is specified, os.path.basename(os.getcwd()) is used to
configure the prompt for the created venv.
@vsajip
Added NEWS entry.
4b2cb68
@vsajip vsajip added the type-feature A feature request or enhancement label Jan 10, 2020
@vsajip vsajip requested a review from brettcannon January 10, 2020 22:34
csabella
csabella reviewed Jan 12, 2020
View reviewed changes
csabella
csabella approved these changes Jan 12, 2020
View reviewed changes
Copy link
Contributor

@csabella csabella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vsajip
Copy link
Member Author

vsajip commented Jan 14, 2020

@brettcannon - as the original reporter - any comments before I merge this?

@brettcannon
Copy link
Member

brettcannon commented Jan 14, 2020

@vsajip my only comment is 🎉😁

@vsajip vsajip merged commit 7d63780 into python:master Jan 14, 2020
@vsajip vsajip deleted the fix-38901 branch January 14, 2020 20:49
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@vsajip @shihai1991
bpo-38901: Allow setting a venv's prompt to the basename of the curre…
3dd3ec9 
…nt directory. (pythonGH-17946)

When a prompt value of '.' is specified, os.path.basename(os.getcwd()) is used to
configure the prompt for the created venv.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon brettcannon approved these changes

@csabella csabella csabella approved these changes

Assignees

No one assigned

Labels

type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vsajip @brettcannon @csabella @the-knights-who-say-ni @bedevere-bot