Skip to content

bpo-39235: Check end_lineno and end_col_offset of AST nodes.#17926

Merged
serhiy-storchaka merged 3 commits into
python:masterfrom
serhiy-storchaka:test-ast-end
Jan 10, 2020
Merged

bpo-39235: Check end_lineno and end_col_offset of AST nodes.#17926
serhiy-storchaka merged 3 commits into
python:masterfrom
serhiy-storchaka:test-ast-end

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Jan 9, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting core review labels Jan 9, 2020
@serhiy-storchaka serhiy-storchaka changed the title bpo-39235 Check end_lineno and end_col_offset of AST nodes. bpo-39235: Check end_lineno and end_col_offset of AST nodes. Jan 9, 2020
@serhiy-storchaka serhiy-storchaka mentioned this pull request Jan 9, 2020
Merged
@gvanrossum

gvanrossum commented Jan 9, 2020

Copy link
Copy Markdown
Member

Should this be backported to 3.8?

Which should be merged first, this one or GH-17925?

Should I still add the test that @pablogsal suggested in GH-17925?

@serhiy-storchaka

serhiy-storchaka commented Jan 9, 2020

Copy link
Copy Markdown
Member Author

I do not want to backport this, because I am not sure that all end positions are correct. If there are incorrect end positions, this can break tests for alternate Python implementations which calculate them correctly.

bab2c12 shows the effect of #17925.

@gvanrossum

gvanrossum commented Jan 9, 2020

Copy link
Copy Markdown
Member

OK. I suppose you have to recalculate now that GH-17925 has landed?

@serhiy-storchaka

serhiy-storchaka commented Jan 10, 2020

Copy link
Copy Markdown
Member Author

Yes, see bab2c12.

@serhiy-storchaka serhiy-storchaka merged commit 850a885 into python:master Jan 10, 2020
@serhiy-storchaka serhiy-storchaka deleted the test-ast-end branch January 10, 2020 08:12
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@serhiy-storchaka @shihai1991
bpo-39235: Check end_lineno and end_col_offset of AST nodes. (pythonG…
4e3828b 
…H-17926)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@serhiy-storchaka @gvanrossum @the-knights-who-say-ni @bedevere-bot