Skip to content

[3.8] bpo-25172: Reduce scope of crypt import tests (GH-17881) #17922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miss-islington merged 1 commit into from
Jan 9, 2020
Merged

[3.8] bpo-25172: Reduce scope of crypt import tests (GH-17881) #17922

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions Lib/test/test_crypt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,20 +6,21 @@
import crypt
IMPORT_ERROR = None
except ImportError as ex:
if sys.platform != 'win32':
raise unittest.SkipTest(str(ex))
crypt = None
IMPORT_ERROR = str(ex)


@unittest.skipIf(crypt, 'This should only run on windows')
@unittest.skipUnless(sys.platform == 'win32', 'This should only run on windows')
@unittest.skipIf(crypt, 'import succeeded')
class TestWhyCryptDidNotImport(unittest.TestCase):
def test_failure_only_for_windows(self):
self.assertEqual(sys.platform, 'win32')

def test_import_failure_message(self):
self.assertIn('not supported', IMPORT_ERROR)


@unittest.skipUnless(crypt, 'Not supported on Windows')
@unittest.skipUnless(crypt, 'crypt module is required')
class CryptTestCase(unittest.TestCase):

def test_crypt(self):
Expand Down