Skip to content

bpo-39191: Fix RuntimeWarning in asyncio test#17863

Merged
miss-islington merged 2 commits into
python:masterfrom
asvetlov:bpo-39191
Jan 7, 2020
Merged

bpo-39191: Fix RuntimeWarning in asyncio test#17863
miss-islington merged 2 commits into
python:masterfrom
asvetlov:bpo-39191

Conversation

@asvetlov

@asvetlov asvetlov commented Jan 6, 2020 •
edited by miss-islington
Loading

Copy link
Copy Markdown
Contributor

@asvetlov
asvetlov requested a review from 1st1 as a code owner January 6, 2020 12:03
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting core review labels Jan 6, 2020
tirkarthi
tirkarthi reviewed Jan 6, 2020
View reviewed changes

@tirkarthi tirkarthi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slightly offtopic, the last patch that caused this warning had a typo _check_runnung which is trivial and can be fixed with this PR.

@asvetlov

asvetlov commented Jan 7, 2020

Copy link
Copy Markdown
Contributor Author

You are right. I've fixed the typo.

tirkarthi
tirkarthi approved these changes Jan 7, 2020
View reviewed changes

@tirkarthi tirkarthi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@miss-islington
miss-islington merged commit 10ac0cd into python:master Jan 7, 2020
@miss-islington

miss-islington commented Jan 7, 2020

Copy link
Copy Markdown
Contributor

Thanks @asvetlov for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Jan 7, 2020

Copy link
Copy Markdown
Contributor

Sorry, @asvetlov, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 10ac0cded26d91c3468e5e5a87cecad7fc0bcebd 3.8

@miss-islington miss-islington self-assigned this Jan 7, 2020
@miss-islington

miss-islington commented Jan 7, 2020

Copy link
Copy Markdown
Contributor

Sorry @asvetlov, I had trouble checking out the 3.7 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 10ac0cded26d91c3468e5e5a87cecad7fc0bcebd 3.7

@bedevere-bot

bedevere-bot commented Jan 7, 2020

Copy link
Copy Markdown

GH-17894 is a backport of this pull request to the 3.8 branch.

asvetlov added a commit to asvetlov/cpython that referenced this pull request Jan 7, 2020
@asvetlov
[3.8] bpo-39191: Fix RuntimeWarning in asyncio test (pythonGH-17863)
1b7539b 
https://bugs.python.org/issue39191.
(cherry picked from commit 10ac0cd)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
@bedevere-bot

bedevere-bot commented Jan 7, 2020

Copy link
Copy Markdown

GH-17895 is a backport of this pull request to the 3.7 branch.

@asvetlov

asvetlov commented Jan 7, 2020

Copy link
Copy Markdown
Contributor Author

Thanks for the review, @tirkarthi

@asvetlov
asvetlov deleted the bpo-39191 branch January 7, 2020 13:28
asvetlov added a commit that referenced this pull request Jan 7, 2020
@asvetlov
[3.8] bpo-39191: Fix RuntimeWarning in asyncio test (GH-17863) (#17894)
4112a3d 
https://bugs.python.org/issue39191.
(cherry picked from commit 10ac0cd)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@asvetlov @shihai1991
bpo-39191: Fix RuntimeWarning in asyncio test (pythonGH-17863)
695263a 
https://bugs.python.org/issue39191
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tirkarthi tirkarthi tirkarthi approved these changes
@1st1 1st1 Awaiting requested review from 1st1

Assignees

@miss-islington miss-islington

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@asvetlov @miss-islington @bedevere-bot @tirkarthi @the-knights-who-say-ni