Skip to content

bpo-39215: Fix SystemError when nested function has annotation on positional-only argument#17826

Merged
pablogsal merged 1 commit into
python:masterfrom
asottile:fix_system_error_posonlyargs_annotations_39215
Jan 5, 2020
Merged

bpo-39215: Fix SystemError when nested function has annotation on positional-only argument#17826
pablogsal merged 1 commit into
python:masterfrom
asottile:fix_system_error_posonlyargs_annotations_39215

Conversation

@asottile

@asottile asottile commented Jan 5, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@ammaraskar ammaraskar requested a review from pablogsal January 5, 2020 01:35
@pablogsal

pablogsal commented Jan 5, 2020

Copy link
Copy Markdown
Member

Thanks for the quick fix, @asottile!

@pablogsal pablogsal merged commit ec007cb into python:master Jan 5, 2020
@miss-islington

miss-islington commented Jan 5, 2020

Copy link
Copy Markdown
Contributor

Thanks @asottile for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Jan 5, 2020

Copy link
Copy Markdown

GH-17827 is a backport of this pull request to the 3.8 branch.

@asottile asottile deleted the fix_system_error_posonlyargs_annotations_39215 branch January 5, 2020 02:14
miss-islington added a commit that referenced this pull request Jan 5, 2020
@miss-islington @asottile
Fix SystemError when nested function has annotation on positional-onl…
8595255 
…y argument (GH-17826)

(cherry picked from commit ec007cb)

Co-authored-by: Anthony Sottile <asottile@umich.edu>
@sthagen sthagen mentioned this pull request Jan 5, 2020
Merged
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@asottile @shihai1991
Fix SystemError when nested function has annotation on positional-onl…
8080428 
…y argument (pythonGH-17826)
@furkanonder furkanonder mentioned this pull request Sep 25, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@asottile @pablogsal @miss-islington @bedevere-bot @the-knights-who-say-ni